Typechecker misses unresolved references inside of variable dimensions about cascade HOT 2 CLOSED

In working on this ticket, I found another error case (they're all fixed now --- with tests to prove it):

localparam GLOBAL = 1;
module foo();
  wire[31:0] x;
  assign x[GLOBAL:0] = 1;
endmodule

from cascade.

The issue ended up having to do with typechecking array subscripts at module declaration time. Since at declaration time, a failed resolution doesn't necessarily imply an error --- just a warning --- the code we had to bail out on further checking in the event of errors wasn't being triggered.

from cascade.