Giter VIP home page Giter VIP logo

Comments (12)

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024 1

Yes, we can.

Further than that, we can add different params to each cards.

If you want, we can open another issue to discuss which params can be added.

from github-profile-summary-cards.

kerthcet avatar kerthcet commented on May 31, 2024 1

I am prefer to make another card with average commit number, it would be more make sense, average commits number charts is not looks good for every people.

How do you think?

IMO, if we plan to add filter params, we can redesign the card with options of yearly, monthly, three monthly, daily and so on. maybe daily default.

We can add timezone parameter first and see how it would be.

Would you like to submit a PR for timezone parameter?

yeah, I would like to have a try. Since I'm busy with my projects, feature will not be complete soon.

from github-profile-summary-cards.

kerthcet avatar kerthcet commented on May 31, 2024 1

ok, I'll have a try. Thanks @vn7n24fzkq

from github-profile-summary-cards.

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024

@kerthcet Thanks for the issue, a configurable timezones would make some charts more readable.

But there are two ways to use this tool, one is GitHub Actions and another is URL usage based on Vercel, if we want to add the parameter for timezone, we have to add the parameter to both usage.

Do you want to add the parameter to both usage?
Or you can add the parameter into one of them, and I will add the parameter to the rest usage.

And I think we should only add the timezone parameter to the card of commits per day hour.
How do you think?

from github-profile-summary-cards.

kerthcet avatar kerthcet commented on May 31, 2024

Of course, timezone is only needed in daily stats card. If I have choice, I prefer the github actions.
By the way, I wonder whether the per day hour stats is an average number, right?

from github-profile-summary-cards.

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024

It is a good point.

The stats is the sum for each day hour in the past year commit activity, it is like the chart of commits per day hour in GitLab.

from github-profile-summary-cards.

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024

We can consider adding another card for average number, or we can just modify stats to average number.

from github-profile-summary-cards.

kerthcet avatar kerthcet commented on May 31, 2024

yep, i also consider whether we can add some params to exclude some projects, especially for top languages by repo and top languages by commit.

from github-profile-summary-cards.

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024

I am prefer to make another card with average commit number, it would be more make sense, average commits number charts is not looks good for every people.

How do you think?

We can add timezone parameter first and see how it would be.

Would you like to submit a PR for timezone parameter?

from github-profile-summary-cards.

kerthcet avatar kerthcet commented on May 31, 2024

do you have a plan about the feature/timezone-parameter? Deadline maybe.

from github-profile-summary-cards.

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024

Because I was plan to do some code refactor recently, can we finish the feature/timezone-parameter in one month?

After that, I can redesign cards when I do the code refactor.

from github-profile-summary-cards.

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024

We can add the timezone as an optional parameter in GitHub Actions, if this usage is okay, then we can do the same thing on other parameters.

from github-profile-summary-cards.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.