Giter VIP home page Giter VIP logo

Comments (22)

MiranDaniel avatar MiranDaniel commented on May 31, 2024 2

Currently working on implementing this, will most likely submit a PR by the end of the week

from github-profile-summary-cards.

MiranDaniel avatar MiranDaniel commented on May 31, 2024 1

Think it would be better to just ignore them from counting, that way the pie chart is always filled at 100%.

from github-profile-summary-cards.

MiranDaniel avatar MiranDaniel commented on May 31, 2024 1

Not sure if we will need include but I don't really think so, nobody really has so many languages that they cannot just list them out all in hidden and if they do, then their summary card isn't very meaningful.
exclude does sound like a better name than hidden though.

from github-profile-summary-cards.

MiranDaniel avatar MiranDaniel commented on May 31, 2024 1

Renamed to exclude, created #97

from github-profile-summary-cards.

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024 1

Sorry for not getting back to you sooner, we are just drafting a release now!
So I think we can close this issue.

from github-profile-summary-cards.

MiranDaniel avatar MiranDaniel commented on May 31, 2024

I'd also like this feature and would like to help out if possible!

from github-profile-summary-cards.

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024

Sorry for the late reply.

Yes! We can add the feature.

For the implementation details, we can just hide the languages or ignore languages from the counting.

How do you think?

from github-profile-summary-cards.

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024

Sounds good, I had the same thought.

from github-profile-summary-cards.

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024

Nice!
We will need to add an optional parameter to GitHub Action usage in action.yml and an URL query parameter in API.
Because we don't have any development documents right now, and the code is a little mess, so feel free to ask any questions.

from github-profile-summary-cards.

MiranDaniel avatar MiranDaniel commented on May 31, 2024

Is there any way to locally run the API server? I'd like to test it as well before making a PR

from github-profile-summary-cards.

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024

https://vercel.com/blog/vercel-dev
I use 'vercel dev'
It may ask you to deploy your own version on vercel, so here are some settings.

Screenshot_20220709-135945~2.png

from github-profile-summary-cards.

MiranDaniel avatar MiranDaniel commented on May 31, 2024

Awesome, got it deployed at https://github-profile-summary-cards-psi.vercel.app/ , just need to make the demo page now!

Example: https://github-profile-summary-cards-psi.vercel.app/api/cards/repos-per-language?username=MiranDaniel&theme=default&hidden=python,html

Want me to make a PR now and then later with the demo page or should I submit it when it's both ready?

from github-profile-summary-cards.

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024

Great!
We can create another PR for the demo page.
By the way, I think maybe using exclude instead of hidden will be a more precise word for this feature. 🤔
Not sure would we need the include in the future.

from github-profile-summary-cards.

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024

But the hidden word is okay to me, use exclude and include at the same time may be confused and have to deal with some tricky problems.

from github-profile-summary-cards.

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024

I have the same thought

from github-profile-summary-cards.

RodrigoDornelles avatar RodrigoDornelles commented on May 31, 2024

Great! We can create another PR for the demo page. By the way, I think maybe using exclude instead of hidden will be a more precise word for this feature. 🤔 Not sure would we need the include in the future.

i think the parameter name hidden is great, because exist another's projects be like.

from github-profile-summary-cards.

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024

Great! We can create another PR for the demo page. By the way, I think maybe using exclude instead of hidden will be a more precise word for this feature. 🤔 Not sure would we need the include in the future.

i think the parameter name hidden is great, because exist another's projects be like.

To me, exclude would be more accurate than hidden, cuz we do not calculate the specific languages and not just hide from the chart.

But consider that user can learn the option usage from other similar projects and we also don't need include actually, hidden is a good word too.

from github-profile-summary-cards.

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024

@MiranDaniel What do you think?

from github-profile-summary-cards.

RodrigoDornelles avatar RodrigoDornelles commented on May 31, 2024

@vn7n24fzkq Why can't I use it yet?

It's already been merged, and I'm trying to test it.

http://github-profile-summary-cards.vercel.app/api/cards/repos-per-language?username=rodrigodornelles&theme=nord_dark&exclude=html,css

from github-profile-summary-cards.

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024

Hi, @RodrigoDornelles.
Because we haven't made a release version yet.
It will be released soon.

from github-profile-summary-cards.

vn7n24fzkq avatar vn7n24fzkq commented on May 31, 2024

I reopened this issue until we actually release this feature.

from github-profile-summary-cards.

kerthcet avatar kerthcet commented on May 31, 2024

+1 for the feature, and maybe better to explain in the readme on which release this will be available, to avoid such confusing also saves your time. :)

from github-profile-summary-cards.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.