Comments (3)
@sammyt was kind enough to find the solution for me: I wasn't calling d.resolve()
in my volofile.
Thus, no problems at all here, sorry about the confusion!
from volo.
To be fair though, it's very easy to forget the call d.resolve
in a volofile. An alternative pattern here is to -- instead of passing a deferred -- require the handler to return a promise in case it's supposed to be asynchronous. If no promise is returned, assume it's synchronous.
from volo.
I can see allowing a promise return, although I still think it is possible for the user to forget to call resolve. I was trying to avoid enforcing volo command creators to adopt promises for their tasks, so I am not comfortable with saying "if no return value it means task complete" path too. I think this is just a hazard of async programming -- if you do not call your callbacks, then things fall down. But it would be good to have some sort of tool that could lint commands, suggest possible problems for cases like these. That seems a bit off in the future though.
from volo.
Related Issues (20)
- .ts files are always downloaded HOT 2
- volo add with amd does not save amd for future reinstall HOT 4
- installing companion css/less/scss file with my js script HOT 2
- external module/lib dependency overrides project dependency HOT 1
- Allow alternate archive HOT 2
- Main module example not creating adapter HOT 1
- Search API needs to be updated
- Update semver package, allow for more semver matching HOT 1
- Define github token on ENV variable in addition to .voloconfigfile
- Volo add local from package.json updates relative path
- Volo visual identity and website design HOT 2
- Do not add dependencies of dependencies to package.json file HOT 1
- volo add library/~version causing TypeError: Invalid Version HOT 1
- URL resolution error when using `volo.url` for github for v0.0.x tags
- Allow volofile.js for those who want to specify file format
- Fragment ID dep with local dependencies installs dir instead of single file.
- add individual file HOT 2
- Cannot assign to read only property 'exitCode' HOT 3
- AWS download URLs need extra handling
- Limit Number of Requests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from volo.