use_deferred $q.defer about angular-wamp HOT 6 CLOSED

@taion I'm using $q.when to wrap the autobahn promise with a $q promise, so that the returned value is a $q promise instead of an autobahn one, which makes it resolve within the digest cycle.

I'm not sure if $q.defer would behave the same way.

Is there a particular issue that this is causing?

from angular-wamp.

Nope, this is just idle speculation - it just looks like the use_deferred connection option would let you skip the wrapping step and just have AutobahnJS directly use the $q.defer constructor instead of having to wrap it. Might be a minor optimization.

from angular-wamp.

@taion Sorry, I didn't understand your original question. I've made this change.

Can you test it out and let me know if it's working as expected?

from angular-wamp.

This change works for me. It's not a big thing, but I think it's a little bit cleaner. You may want to undocument the deferral-related options, since they're no longer relevant, though:

from angular-wamp.

All options can be overwritten in the config. I'm not sure if there really is a use case for changing the deferred or not, but I'll leave it there for consistencies sake and just add a note.

from angular-wamp.

The only case I can really think of where you'd want something beyond the $q.defer might be for angular-poller, because it's a bit annoying that those promises can't ever get resolved, so they can't go into a route's resolve block. That's quite a stretch, though, and presumably you wouldn't be using angular-poller if you're using something WAMP-based anyway.

Thanks!

from angular-wamp.