Giter VIP home page Giter VIP logo

Comments (4)

txaj avatar txaj commented on September 24, 2024

Hi @vchepkov thanks for the report.

  1. Obviously the classes you're talking about are missing $ensure as a parameter. You can add it and default it as present
  2. $base_filename does not seems used at all. just grep that string on the master branch, confirm it's not used anywhere then you can simply delete that line.
  3. I am unsure about this ; concat is a meta parameter, that should not be an issue. If you can find a case where it's an issue I could look deeper. PR'ing a test triggering that case would be great :-)
  4. this type is deprecated anyway. @blkperl how should we handle this ? PR for deprecated things you'd merge at the next major release ?

from puppet-collectd.

blkperl avatar blkperl commented on September 24, 2024

Please submit a PR for the bugs you found. The deprecated things can be removed and I'll bump the version number to 5.0

from puppet-collectd.

igalic avatar igalic commented on September 24, 2024
  1. looks fixed to me.

what's the status on the other bits? ping @vchepkov / @txaj

from puppet-collectd.

jyaworski avatar jyaworski commented on September 24, 2024

Closing due to lack of movement. Please re-open if needed.

from puppet-collectd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.