Giter VIP home page Giter VIP logo

Comments (7)

tarjei avatar tarjei commented on September 24, 2024
--- a/modules/collectd/manifests/plugin/python.pp
+++ b/modules/collectd/manifests/plugin/python.pp
@@ -12,9 +12,9 @@ define collectd::plugin::python (
   validate_hash($config)

   if $::osfamily == 'Redhat' {
-    package { 'collectd-python':
-      ensure => $ensure,
-    }
+#    package { 'collectd-python':
+#      ensure => $ensure,
+#    }
   }

from puppet-collectd.

nibalizer avatar nibalizer commented on September 24, 2024

Thanks for the contribution. Can you open this as a pull request?

from puppet-collectd.

jesusaurus avatar jesusaurus commented on September 24, 2024

Also, can you remove the package resource rather than commenting it out?

from puppet-collectd.

blkperl avatar blkperl commented on September 24, 2024

You need to add a conditional on the version of redhat around the package resource. You can't just comment it out or it breaks the module for RHEL6 and RHEL5.

from puppet-collectd.

tarjei avatar tarjei commented on September 24, 2024

This wasn't actually meant as a PR, put as a tip to where to change the code :)

from puppet-collectd.

bzed avatar bzed commented on September 24, 2024

Using ensure_packages from stdlib would be very appreciated....

from puppet-collectd.

blkperl avatar blkperl commented on September 24, 2024

Released in #254

from puppet-collectd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.