Giter VIP home page Giter VIP logo

Comments (5)

tobru avatar tobru commented on June 23, 2024

Thanks for your suggestion. Would you mind creating a tested PR for this? That would make things easier as I don't have access atm to an Amazon AMI to test it.

from puppet-gitlab.

cagriersen avatar cagriersen commented on June 23, 2024

Hi again,

I've just modified the code -in a dirty way- to quick fixing:

        if ($::operatingsystem == 'Redhat' and ($::operatingsystemmajrelease == '6' or $::operatingsystemmajrelease == '7')) {
          $releasever = $::operatingsystemmajrelease
        } elsif ($::operatingsystem == 'Amazon' and $::operatingsystemmajrelease == '2015') {
          $releasever = '6'
        }

from puppet-gitlab.

tobru avatar tobru commented on June 23, 2024

Would you mind creating a PR for this changes?

from puppet-gitlab.

tobru avatar tobru commented on June 23, 2024

@cagriersen Is this still an issue? If yes, would you mind creating a PR?

from puppet-gitlab.

tobru avatar tobru commented on June 23, 2024

As I don't have an Amazon AMI available right now to test this issue and no tested PR has been made, I'll close this issue for now. If someone is able to provide a proper PR, I'm happy to merge it to have support for Amazon Linux.

from puppet-gitlab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.