Giter VIP home page Giter VIP logo

Comments (5)

mcanevet avatar mcanevet commented on June 20, 2024

@lazyfrosch where do you add ".strip!" ?

from puppet-openldap.

lazyfrosch avatar lazyfrosch commented on June 20, 2024

Just after the slappasswd execution.

diff --git a/lib/puppet/parser/functions/openldap_password.rb b/lib/puppet/parser/functions/openldap_password.rb
index bdfeefb..8ac8be8 100644
--- a/lib/puppet/parser/functions/openldap_password.rb
+++ b/lib/puppet/parser/functions/openldap_password.rb
@@ -11,6 +11,6 @@ module Puppet::Parser::Functions
     scheme = args[1] if args[1]
     command << ['-h', scheme] if scheme

-    Puppet::Util::Execution.execute(command.flatten)
+    Puppet::Util::Execution.execute(command.flatten).strip!
   end
 end

from puppet-openldap.

mcanevet avatar mcanevet commented on June 20, 2024

@lazyfrosch what ruby version are you using ?

from puppet-openldap.

lazyfrosch avatar lazyfrosch commented on June 20, 2024

@mcanevet The system is a vagrant box based on Debian Wheezy, Ruby is 1.9.3.194-8.1+deb7u2

from puppet-openldap.

mcanevet avatar mcanevet commented on June 20, 2024

@lazyfrosch I'm not sure that '!' is mandatory in this case.
Could you provide a PR with your patch (without '!' if it's not necessary) ?

from puppet-openldap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.