Giter VIP home page Giter VIP logo

Comments (5)

acullenn avatar acullenn commented on July 3, 2024 2

Hey @siebrand - yeah this is what I was aiming to accomplish. I'm currently using a fork in which it works well.

I think the barrier was the issue @smortex was referring to - in which two pyvenvs cannot share the same requirements.txt. I think it's worth noting though that I encounter this with upstream and with my branch. I'm not sure how to resolve that issue. But setting the local subscribe to undef doesn't appear to matter, at least from my testing.

from puppet-python.

smortex avatar smortex commented on July 3, 2024 1

Hi @siebrand

It's unknown to me how to try and get more attention for this ticket...

The most efficient way to move on is probably to open a PR with a first commit that add a failing test that reproduce the problem you encounter. Then add a second commit to implement a fix.

This make it easier for contributors to reproduce the issue and tinker with the issue to fix it the best possible way.

Thanks!

from puppet-python.

acullenn avatar acullenn commented on July 3, 2024

Experiencing the exact same issue, though it's worth noting that it only seems to occur on puppet 6.x hosts. When I run my bolt plan that leverages this module against a host with puppet 4.8 I do not encounter this issue.

Puppet: 6.18.0 (client) / 6.19.1 (bolt host)
Ruby: ruby 2.4.10p364 (2020-03-31 revision 67879) [x86_64-linux] (client) / ruby 2.6.3p62 (2019-04-16 revision 67580) [universal.x86_64-darwin19] (bolt host)
Distribution: CentOS 7.7
Module version: 6.0.0 / 6.1.0

Requirements file is not enforced, verbose puppet logs indicate python::requirements class never ran.

The fix @siebrand indicated worked for me as well. What's the purpose of setting subscribe to undef in this instance?

If there isn't one, I'm happy to open a PR for this fix. Tested against hosts running Centos 7.7, 7.9 and against Puppet Agent versions 4.8.2, 6.18.0

from puppet-python.

siebrand avatar siebrand commented on July 3, 2024

I'm going to resolve to forking because I can't really wait for this to get attention. Could a committer please comment what the issue is with this ticket and the proposed solution? It's unknown to me how to try and get more attention for this ticket...

from puppet-python.

siebrand avatar siebrand commented on July 3, 2024

This make it easier for contributors to reproduce the issue and tinker with the issue to fix it the best possible way.

Thanks for your reply, @smortex. I understand that. I am however completely unfamiliar with testing for puppet classes. So I tried to analyze, and explain in my report as best as I could.

It's unknown to me how to try and get more attention for this ticket...

The most efficient way to move on is probably to open a PR with a first commit that add a failing test that reproduce the problem you encounter. Then add a second commit to implement a fix.

Isn't this what @acullenhms did in #619? It's been waiting for attention since 2021-08-27.

from puppet-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.