Feature Request: support for redis-sentinel about puppet-redis HOT 7 CLOSED

I haven't got anything in progress but I'd gladly accept patches!
Other enhancements are welcome too.

from puppet-redis.

Cool, this is on my todo list for this week. There are some hurdles to overcome with the sentinel.conf file (which the sentinel process will write state to) but I've seen some ways around that.

from puppet-redis.

Looking forward to seeing some patches. 👍
You could use augeas so you don't have to manage the entire file which would otherwise result in a race condition.

from puppet-redis.

I'll be doing the work on this fork+branch: https://github.com/cdent/puppet-redis/tree/sentinel-support

Do you prefer the eventual pull request (assuming I can get it working, which I'm pretty sure I can) squashed or with all the history?

from puppet-redis.

Excellent. I see you already got started. :)

Well it depends on how many commits you're going to end up with.
If it's +50 I'd prefer some of them squashed, but if it's 10 commits by all means leave it in.

Keep up the good work!

from puppet-redis.

I've left a few comments in the message of today's commit that you might want to weigh in on: cdent@8206296

They basically surround questions on how or if to deal with config directories and log files.

from puppet-redis.

Released in f4ffa1b

Awesome, thanks for the quick handling.

from puppet-redis.