No Hiera support about puppet-selinux HOT 6 CLOSED

I think the correct hiera entry would be:

selinux::selinux_booleans:
  httpd_can_network_relay:
    ensure: on

from puppet-selinux.

Seems weird as the code in the boolean.pp is:

#  selinux::boolean{ 'named_write_master_zones':
#     ensure     => "on",
#     persistent => true,
#  }
#

define selinux::boolean (
  $ensure     = 'on',
  $persistent = true,
) {
......
}

from puppet-selinux.

Aha, I had misread your original comment, or more specifically the code starting at line 33 of the selinux init class. I believe the problem is that specifying in code empty hashes as default values for parameters prevents puppet from doing automatic hiera lookup, as that lookup only does native merging and not deep merging.

Try changing lines 33 to 36 in init.pp as such:

  $selinux_booleans,
  $selinux_modules,
  $selinux_fcontexts,
  $selinux_ports

Then change lines 63 to 66 to be this:

  if $selinux_booleans {
    create_resources('selinux::boolean', $selinux_booleans)
  }
  if $selinux_modules {
    create_resources('selinux::module', $selinux_modules)
  }
  if $selinux_fcontexts {
    create_resources('selinux::fcontext', $selinux_fcontexts)
  }
  if $selinux_ports {
    create_resources('selinux::port', $selinux_ports)
  }

At that point, the following hiera should work as expected:

selinux::selinux_booleans:
  httpd_can_network_relay:
    ensure: on

Note that I'm not a maintainer of this module. You'd want to submit a PR with these changes to get their attention.

from puppet-selinux.

Thanks.
I will prepare a PR.

from puppet-selinux.

I just created the PR #128

from puppet-selinux.

Issue fixed

from puppet-selinux.