Giter VIP home page Giter VIP logo

Comments (8)

mkrakowitzer avatar mkrakowitzer commented on June 17, 2024

Yeah I think this would be a useful feature and it should be added. Is this something you would consider submitting a pull request for?

from puppet-stash.

nibalizer avatar nibalizer commented on June 17, 2024

+1 for this feature.

from puppet-stash.

wayn3w avatar wayn3w commented on June 17, 2024

I can work on it and submit a pull request; it'll take me a little bit to get it done.

from puppet-stash.

mkrakowitzer avatar mkrakowitzer commented on June 17, 2024

Sounds good, let me know if you need any assistance. We have been waiting 2+ years for this feature so take as much time as you need :)

from puppet-stash.

claflico avatar claflico commented on June 17, 2024

Rather than hard-coding variables & the template for each of the system properties (i.e. jdbc, jmx, setup automation) would it be better to make the entire template file able to be managed? You shouldn't have to define defaults for each of the variables as it sounds like they are already in stash and only need to be specified if you want to override the default stash value: https://confluence.atlassian.com/display/STASH/Stash+config+properties

Our devs are wanting to add this but I told them that custom properties weren't supported by the module yet and that I wasn't wanting to snowflake the server for it: https://confluence.atlassian.com/display/STASH/Stash+config+properties#Stashconfigproperties-Pullrequests

from puppet-stash.

mkrakowitzer avatar mkrakowitzer commented on June 17, 2024

The JMX configuration requires more than just changes to stash-config.properties files. The setenv.sh also need to be updated.

That being said we should allow a global parameter to all settings in https://confluence.atlassian.com/display/STASH/Stash+config+properties to be configured. Can you raise a seperate issue for this? Its quick do to so ill work on it tonight.

from puppet-stash.

claflico avatar claflico commented on June 17, 2024

done

from puppet-stash.

jyaworski avatar jyaworski commented on June 17, 2024

Hello:

What is the status of this issue?

from puppet-stash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.