Giter VIP home page Giter VIP logo

Comments (8)

johnny5v avatar johnny5v commented on June 23, 2024

Using class makes more sense. Agree .

from puppet-systemd.

felixb avatar felixb commented on June 23, 2024

👍

from puppet-systemd.

faxm0dem avatar faxm0dem commented on June 23, 2024

Should we use a define or a class?
Which would make more sense (see also #5)

from puppet-systemd.

faxm0dem avatar faxm0dem commented on June 23, 2024

After discussing this with @Volcane on IRC, it came out that it would probably make sense to go further with the abstraction, and to provide a systemd::unit defined type which would take care of everything.

from puppet-systemd.

felixb avatar felixb commented on June 23, 2024

@faxm0dem I've created a proposal PR for this already in #4.

from puppet-systemd.

raphink avatar raphink commented on June 23, 2024

#4 has been merged. I see from #5 that there was a suggestion still to use defines to avoid the problems described by @roidelapluie. Is that still a plan?

from puppet-systemd.

reenberg avatar reenberg commented on June 23, 2024

Am I wrong in saying that this and #5 can be closed as this was implemented using a class in #18?

from puppet-systemd.

faxm0dem avatar faxm0dem commented on June 23, 2024

I agree, thanks for noting this!

from puppet-systemd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.