Comments (11)
I think anything generic would just be a trivial wrapper around puppetlabs-inifile so may as well just use inifile type.
The benefit of having things in this module is the strong validation.
from puppet-systemd.
from puppet-systemd.
Many of those configs can already be managed with this module. See https://github.com/voxpupuli/puppet-systemd/tree/master/manifests where we have journald.pp
, logind.pp
, networkd.pp
, system.pp
, and timesyncd.pp
.
from puppet-systemd.
from puppet-systemd.
Sounds like that would be something nice to add with a pull request if you need that functionality. I use this module to configure my systems to use systemd-networkd
, but didn't need to change anything in /etc/systemd/networkd.conf
.
from puppet-systemd.
I think the benefit of this module is to allow hiera to manage most of the data change, which when looking at the mentioned services is the creation of ".d" directories, file creation with content and reload of service. This seems more than just a simple wrapper of the "puppetlabs-inifile" library.
I'm sure that with a little bit of tweeting, we can get systemd::dropin to do the heavy lifting. Is anyone working on a PR for this? If not, I might look to raise one?
from puppet-systemd.
@ptiggerdine Can't tell if someone is working on this, but I believe it would be valuable if someone did, and so far no one raised their voice. Therefore, please do. :)
from puppet-systemd.
Since ticket was written , logind.conf , crashcore.conf journald.conf and others are all supported.
Doing each file one file at a time makes sense.
Configuring systemd-X.conf
is often more than just doing the file, e.g packages have to be installed , services restarted ,...
Re the networkd.conf for sure open a particular issue.
Can we close this.
from puppet-systemd.
Thanks, I think this could be closed.
from puppet-systemd.
I really don't understand the logic and decision here to "not" control /etc/systemd/*.conf files.
After all this is the systemd module but we can't configure basic systemd settings.
Then someone goes and does something like this?
https://github.com/voxpupuli/puppet-systemd/blob/master/manifests/system.pp#L8
Technically, I can define any setting in system.conf with this very class, however the was implemented to only consider accounting settings and forces them.
So something like this:
hiera.yaml
---
systemd::manage_accounting: true
systemd::accounting:
DefaultLimitNOFILE: '1024:262144'
results:
nfo: Applying configuration version '1706563751'
Notice: /Stage[main]/Systemd::System/Ini_setting[DefaultCPUAccounting]/ensure: created
Notice: /Stage[main]/Systemd::System/Ini_setting[DefaultBlockIOAccounting]/ensure: created
Notice: /Stage[main]/Systemd::System/Ini_setting[DefaultMemoryAccounting]/ensure: created
Notice: /Stage[main]/Systemd::System/Ini_setting[DefaultTasksAccounting]/ensure: created
Notice: /Stage[main]/Systemd::System/Ini_setting[DefaultIOAccounting]/ensure: created
Notice: /Stage[main]/Systemd::System/Ini_setting[DefaultIPAccounting]/ensure: created
Notice: /Stage[main]/Systemd::System/Ini_setting[DefaultLimitNOFILE]/value: value changed [redacted sensitive information] to [redacted sensitive information]
Why not make make make control of these files configurable?
manage_system_conf: BOOL
manage_user_conf: BOOL
manage_network_conf: BOOL
...
I would be happy to submit a PR but I don't want to put in the effort if the community does not agree with this module taking control of these files.
Thoughts?
from puppet-systemd.
I really don't understand the logic and decision here to "not" control /etc/systemd/*.conf files. After all this is the systemd module but we can't configure basic systemd settings.
@derekmpage there is no such single thing as "/etc/systemd/*.conf
". There are files matching that pattern, some of which can be managed with this module. See #232 (comment)
Then someone goes and does something like this?
https://github.com/voxpupuli/puppet-systemd/blob/master/manifests/system.pp#L8
That was added in 2018 with #65. This issue was created in 2021.
Why not make make make control of these files configurable?
manage_system_conf: BOOL manage_user_conf: BOOL manage_network_conf: BOOL ...
I would be happy to submit a PR but I don't want to put in the effort if the community does not agree with this module taking control of these files.
Thoughts?
Being able to manage more of system.conf, and systemd in general, sounds like a good enhancement to me.
from puppet-systemd.
Related Issues (20)
- manage_unit service_entry Environment can't have multiple values HOT 3
- Running the example code for `systemd::manage_unit` from REFERENCE.md causes an error:
- Add possibility to setup limits for user sessions HOT 6
- IODeviceWeight, IOReadIOPSMax, .. do not work in systemd::manage_unit or systemd::dropin_file HOT 1
- Missing parameters under Service section HOT 2
- Provide possibility to disable service restart upon unit file change
- Add hiera-friendly option to manage dropins HOT 2
- Add `NetworkNamespacePath` to unit service HOT 4
- Allow specifying multiple Environment variable HOT 2
- Usage of `systemd::escape` in `systemd::timer_wrapper` creates weird names HOT 7
- [4.1.0] ignore active+enable when ensure is set to absent for systemd::timer HOT 1
- Issue with hiera since v 7.0.0 HOT 2
- systemd::user_service broken for puppet running in background HOT 3
- Deprecation of systemd::service_limits unexpectedly causes service restarts in some scenarios HOT 7
- Add support for systemd link files HOT 2
- Allow systemd unit specifiers in path values HOT 2
- Setting default_target fails due to deprecated shell_escape function HOT 2
- Inconsistent values for `notify_service` in replacement for `systemd::service_limits` HOT 1
- udev rules not reloaded after change
- Unit file path inconsistency HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppet-systemd.