Hiera not merging output options correctly. about puppet-telegraf HOT 5 OPEN

+1 for having this use case. We often have hosts that need to collect some service specific metrics, and adding those is a bit cumbersome.

We ended up doing this in inputs in the resource spec:

    inputs              => {
      ...
      mem    => [ {} ],
      io     => [ {} ],
      net    => [ {} ],
      system => [ {} ]
    } + lookup('ndn::telegraf.inputs', {default_value => [{}], merge => deep}),

So we could add additional inputs per host.

from puppet-telegraf.

@htj The ability to configure merge behaviour was added in #134
Does this work for you?

from puppet-telegraf.

@alexjfisher

I had several issues getting this to work. Having:
merge_hash_arrays: true
Option in common.yaml as listen in:
https://github.com/voxpupuli/puppet-telegraf/pull/99/commits
Make it possible to have multiple inputs of the same type (we often have multiple inputs.exec for custom collections)

However this did not make it possible to have multiple
telegraf::inputs:
As one would always wine. I suspect it has something to do with look hiarchy, but I don't understand Puppet well enough to debug it.

from puppet-telegraf.

The lookup_options in https://github.com/voxpupuli/puppet-telegraf/blob/777e608c000655781179913d9ee41aacd216c8c0/data/defaults.yaml are just the defaults. You can override lookup_options in your environments hiera, for example in your node specific hiera data. See https://puppet.com/docs/puppet/latest/hiera_merging.html#overriding-merge-behavior

If you still can't make it merge the way you need it to, could you provide some specific examples of what you're trying to achieve?

from puppet-telegraf.

Changing lookup_options in the module to this:

---
lookup_options:
  'telegraf::inputs':
    merge:
      strategy: deep
      merge_hash_arrays: true
  'telegraf::outputs':
    merge:
      strategy: deep
      merge_hash_arrays: true

resolves the issue.

from puppet-telegraf.