Giter VIP home page Giter VIP logo

Comments (5)

jairojunior avatar jairojunior commented on June 18, 2024

👍

That's very interesting. It opens a door for a lot of possibities.

Management API docs used to be really shallow when I started writing this module. Always had to write something in CLI and convert to HTTP API syntax, even had to investigate Management Console interactions with HTTP API to better understand this...

Do you think we should have a custom type that supports plain JSON requests? So people could tests commands using HTTP API before using it in the module.

from puppet-wildfly.

bjwschaap avatar bjwschaap commented on June 18, 2024

I'm not sure. I'm leaning on two different thoughts regarding this:

  • it would be nice to have this as a 'last resort' type to get things done with the module even when there's no specific type for it (this is what I actually use wildfly::util::resource for right now)
  • on the other hand this would be the exec type of Wildfly. And I think using exec is bad. Well, at least 99% of the time... An exec can always be replaced with a custom type.

What do you think @jairojunior?

from puppet-wildfly.

jairojunior avatar jairojunior commented on June 18, 2024

It's nice when you automate a task and are able to easily transport it to Puppet, but as you suggested, we should stick the simple for now.

Let's just introduce a new parameter for operation headers in our custom types.

👍

from puppet-wildfly.

jairojunior avatar jairojunior commented on June 18, 2024

Operation headers are now supported with the new CLI Parser implemented in v1.0.0 branch and it should work for wildfly_cli. Just need to introduce this parameter for wildfly_resource and wildfly_deployment.

Not sure whether should use CLI syntax:

wildfly_resource { '/resource=name':
  operation_headers => '{header1=value;header2=value}'
}

Or a typed alternative which I would be able to validate headers name:

wildfly_resource { '/resource=name':
  operation_headers => {'rollback-on-runtime-failure' => false}
}

from puppet-wildfly.

jairojunior avatar jairojunior commented on June 18, 2024

Done for wildfly_resource and wildfly_deployment and its wrappers. Tested for wildfly_cli using {header1=value;header2=value} syntax.

from puppet-wildfly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.