Doesn't seem to work with elasticsearch-dsl/djagno-elasticsearch-dsl about elasticmock HOT 13 CLOSED

I could reproduce your error yesterday. I will work on it today :)

from elasticmock.

I've created a branch to us to work on that: https://github.com/vrcmarcos/elasticmock/tree/barseghyanartur

I had found the error and now we need to mock the bulk method. Could you help me in this, @barseghyanartur ? :)

Note that I've left some ipdb.set_trace() in the code in order to you check the critical points

from elasticmock.

I'm closing this, because at the end testing without Elastic does not make sense. And testing with Elastic is so simple, that there's practically no need for mocking (unless you have a very complicated case, which I at the moment of writing can't think of).

from elasticmock.

Hi @barseghyanartur ! Thanks for posting this issue!

Could you post the elasticsearch, elasticsearch-dsl and django-elasticsearch-dsl libs version?

from elasticmock.

@vrcmarcos:

I tried it with:

elasticsearch==2.4.1
elasticsearch-dsl==2.2.0
https://github.com/sabricot/django-elasticsearch-dsl/archive/master.zip

django-elasticsearch-dsl installed from master.

I tried the same with latest versions as well.

elasticsearch==5.3.0
elasticsearch-dsl==5.3.0

from elasticmock.

@vrcmarcos:

Did you have time for digging into it?

from elasticmock.

Sorry @barseghyanartur , I didn't debugged this yet :(

But the lib was designed to run with elastic 1.x and Python 2.7. But with some minor changes it can be fully functional to other versions

from elasticmock.

The root cause of this error is this: elasticsearch/connection/http_urllib3.py:89: ConnectionError. We need to properly patch this function and prevent the original from being called

from elasticmock.

@vrcmarcos:

I'm sorry, I don't seem to get free time for this: not at work and not in my free time.

from elasticmock.

@vrcmarcos, @barseghyanartur: Do you two have time to work on this soon? elasticmock seems to be broken with the elasticsearch==5.4.0 library.

from elasticmock.

@nhooey:

I don't think I need it that much. I use elasticsearch-dsl-py and connections are executed in runtime (function/method level) only. I have Elasticsearch 5 installed locally annd 2.x running using Vagrant/VirtualBox.

from elasticmock.

Could you also elaborate on what the exact issue is? I'm trying to fix it now.

I'm looking at your branch, and you mentioned that the bulk method needs to be mocked. Is that all that needs to be done?

from elasticmock.

Sorry @nhooey , I can not have time to maintain this library. I'm accepting PR and giving merge power to some guys who are sending PRs.

from elasticmock.