Giter VIP home page Giter VIP logo

Comments (7)

vtourraine avatar vtourraine commented on September 4, 2024

Thank you for your question, Parvez!

If I understand correctly, the answer is no. That’s because this library was originally focused on presenting CocoaPods dependencies inside the main app, and as you pointed out, CocoaPods already generates the Settings bundle.

So I’m curious how you would use this now. To list SPM dependencies in the Settings? (SPM doesn’t support licences, so this would be a very basic list.)

from acknowlist.

parvez-keeptruckin avatar parvez-keeptruckin commented on September 4, 2024

Apple must be aware of such things so they must provide some way of listing out dependencies similar to CocoaPods as some libraries prefers that this should be displayed.

from acknowlist.

vtourraine avatar vtourraine commented on September 4, 2024

Well, to my knowledge, the SPM specifications don’t include the license. A Package.swift file cannot specify the license, unlike CocoaPods’s podspec format.

from acknowlist.

parvez-keeptruckin avatar parvez-keeptruckin commented on September 4, 2024

@vtourraine I am trying out AcknowList now. As per instructions given in the ReadMe section, I noticed few things so can you clarify on these?

  • I added AcknowList via SPM and subsequently added Package.resolved to application target as perinstructions. Besides this I have SDWebImage added via SPM but rest of the libraries are via CocoaPods. When I open AcknowListViewController() in the app, it is only showing AcknowList and SDWebImage. When I click on any of these items in the list then it is opening the respective Github page instead of the License. Also I do not see any item related to CocoaPods libraries. I initialised the view controller simply as AcknowListViewController(). I am using Xcode 15.0. Am I missing any step here ?

from acknowlist.

vtourraine avatar vtourraine commented on September 4, 2024

When I click on any of these items in the list then it is opening the respective Github page instead of the License.

SPM doesn’t support licenses, so we’re showing the library repo instead. For CocoaPods dependencies, it will show the license.

Also I do not see any item related to CocoaPods libraries.

Have you added the acknowledgements plist file to your main target? If you follow the instructions here, it will try to load both the SPM and CocoaPods dependencies and merge them for display.

from acknowlist.

parvez-keeptruckin avatar parvez-keeptruckin commented on September 4, 2024

Does it makes sense to show the repo page in case of swift packages? For private repo providing swift package where it will navigate ?

from acknowlist.

vtourraine avatar vtourraine commented on September 4, 2024

Does it makes sense to show the repo page in case of swift packages?

If the library has a license, it would typically be in the repo. So I think it makes sense, given the info we have.

For private repo providing swift package where it will navigate?

It would probably show a GitHub 404. For private dependencies, I would suggest either removing the acknowledgement item or editing the URL/license to put something custom. You can modify the acknowledgements property on AcknowListViewController between the init and presenting the controller.

from acknowlist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.