Giter VIP home page Giter VIP logo

Comments (4)

cexbrayat avatar cexbrayat commented on June 5, 2024 1

Hi @occitaneUbald

This is because of this fix in VTU #2231
But I think the new behavior is probably better.

You'll have to update your test to either:

  • check with TrimmedExample
  • check both span elements individually withelement.textContent if you want to check if the space is there (because text() does trim the content).

from test-utils.

occitaneUbald avatar occitaneUbald commented on June 5, 2024

You should at least mention this in your changelog as it is a breaking change in your API

from test-utils.

cexbrayat avatar cexbrayat commented on June 5, 2024

Maybe we should have, but I don't think it was spotted by the contributor who did this fix.

Feel free to open a PR to open the changelog, we'll gladly review it.

from test-utils.

occitaneUbald avatar occitaneUbald commented on June 5, 2024

And we should probably add an automated test to avoid further undetected regressions in the future on this API

from test-utils.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.