Giter VIP home page Giter VIP logo

Comments (6)

msporny avatar msporny commented on August 15, 2024 3

it should raise an error.

from vc-bitstring-status-list.

dlongley avatar dlongley commented on August 15, 2024 2

non normative 406 might be a sane path as well as normative on throw an error

The index isn't sent to the server that provides the status list VC, so this would be a client-side / verifier error, I'd think. So an HTTP status code doesn't seem right here. If you're referring to something like a verifier service provided by the VC API ... I'd expect the appropriate behavior to be defined in that spec.

from vc-bitstring-status-list.

mprorock avatar mprorock commented on August 15, 2024

non normative 406 might be a sane path as well as normative on throw an error

from vc-bitstring-status-list.

iherman avatar iherman commented on August 15, 2024

The issue was discussed in a meeting on 2023-01-31

  • no resolutions were taken
View the transcript

2.4. Bounds checking (issue vc-status-list-2021#9)

See github issue vc-status-list-2021#9.

Brent Zundel: if the index is out of bounds... what should happen.

Manu Sporny: it should raise an error.
… if they are out of bounds, it should raise an error..

Michael Prorock: ill volunteer for a PR on this.

Kristina Yasuda: I don't disagree... throwing an error is fine, but perhaps we should define an error code?.
… are there error codes?.

Manu Sporny: checking the status index is part of the verification stage.
… that would cause verify to fail.
… it gets into protocol.

Kristina Yasuda: error message?.

Manu Sporny: all we can say is you should throw an error.
… we don't have error codes yet.
… there is no way to surface these to the caller, unless we talk about protocol like vc api.
… i don't think this spec, which is just data model and serialization, can say much about how errors are exposed.

Michael Prorock: i'm not opposed to including informative guidance.
… like 406 / not acceptable.
… normative path, we should say MUST throw an error.

Phil ASU: +1 to it should throw an error.

Michael Prorock: should users see it? we can't say anything about that.

Michael Prorock: +1 manu.

Manu Sporny: is there confusion over getting the list, like 404... vs during verification 406 might not make sense... maybe better 200 verified false.
… seems like a protocol trap.

Michael Prorock: agreed.

Kristina Yasuda: good point on retrieval vs verify in the bitmap.
… we should say 404 if its obvious is should be 404.

Manu Sporny: +1 kristina, not finding the status list should be a 404 and should be in the spec..

Kristina Yasuda: if we want to avoid protocol, error message is probably also a trap.

Manu Sporny: we can define an algorithmic error message.
… error_index_out_of_bounds and hand wave about it.
… languages / implementers can define how they want to handle it.

Michael Prorock: +1 manu, e.g. you MUST return an error that indicates that the index is out of range through ERR_ABOVE_MAX.

from vc-bitstring-status-list.

msporny avatar msporny commented on August 15, 2024

PR #104 has been raised to address this issue. This issue will be closed once PR #104 has been merged.

from vc-bitstring-status-list.

msporny avatar msporny commented on August 15, 2024

PR #104 has been merged, closing.

from vc-bitstring-status-list.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.