Misleading name: addSAMSitesByPrefix about skynet-iads HOT 3 OPEN

To be fair, that would break all existing scripts, we handle a lot of changes with MOOSE functions and the best approach is to make two completely new functions and handle the legacy function nicely so it doesnt break anything. This kind of short name confusion on methods does do this often, the observation is completley valid, but the solution should be less severe. Just a thought.

from skynet-iads.

In general I agree with you that it has the potential to break scripts.
BUT who really uses this function to change the samsites?
Honestly, marking the function as deprecated and add 2 new functions seems to be the best way.

from skynet-iads.

fair point @Codingboy will add ad setSAM method that behaves like the add one and update the add behaviour. Will add it to the next major version release. In this case I don‘t think it would break existing missions, since its a rather small change in behaviour

from skynet-iads.