Giter VIP home page Giter VIP logo

Comments (2)

pimeys avatar pimeys commented on July 28, 2024

Hi,

It's been a while since I've worked with apple notifs and our company is no more. So I need to think a bit how my reasoning was here...

Our notification consumer is now also open source and here you see me mapping the errors:
https://github.com/xray-tech/xorc-notifications/blob/master/src/apns2/consumer.rs#L127

  • Ok is a successful notification and we don't do anything.
  • Err(Error::ResponseError(e)) is an error from apple while processing the notification.
  • Err(e) is an error that happened while connecting or transferring data. Something that is fatal.

Might not be so kosher anymore in 2019, but now if we're breaking the API, could you write a pull request as a proposition how you'd want to break it and we could discuss it more, allowing people already using the crate to also participate?

Maybe would be even nicer to integrate crates such as failure to the mix.

from a2.

ShaneQi avatar ShaneQi commented on July 28, 2024

Thanks for the response and the open mind.

I will open a PR if I can convert my thought into a reasonable change.

PS:

Thanks for the example code of your consumer, it helps a lot.

from a2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.