Comments (2)
Hi,
It's been a while since I've worked with apple notifs and our company is no more. So I need to think a bit how my reasoning was here...
Our notification consumer is now also open source and here you see me mapping the errors:
https://github.com/xray-tech/xorc-notifications/blob/master/src/apns2/consumer.rs#L127
Ok
is a successful notification and we don't do anything.Err(Error::ResponseError(e))
is an error from apple while processing the notification.Err(e)
is an error that happened while connecting or transferring data. Something that is fatal.
Might not be so kosher anymore in 2019, but now if we're breaking the API, could you write a pull request as a proposition how you'd want to break it and we could discuss it more, allowing people already using the crate to also participate?
Maybe would be even nicer to integrate crates such as failure to the mix.
from a2.
Thanks for the response and the open mind.
I will open a PR if I can convert my thought into a reasonable change.
PS:
Thanks for the example code of your consumer, it helps a lot.
from a2.
Related Issues (20)
- Breaking a2 into separate crates HOT 2
- Upgrade Crossbeam HOT 4
- http2 error: protocol error: not a result of an error HOT 2
- Compilation broken with latest nightlies HOT 1
- Default apns_priority doesn't match expectation HOT 4
- changed lifetimes HOT 8
- 'tokio-runtime-worker' has overflowed its stack fatal runtime error: stack overflow
- Upgrade to tokio 0.3 HOT 3
- Upgrade to tokio 1.0 HOT 1
- Getting an issue with 'executor must be set' HOT 4
- API compatibility breakage in new minor version v0.6.2 HOT 2
- Panic: 'executor must be set' from hyper-0.14.15 when running examples.
- feat: `.editorconfig`
- fix: add `tracing` feature back
- feat: Switch `&str` params HOT 4
- Client panicked inside hyper-alpn library
- Sending a payload with invalid uri chars panics
- async-std support? HOT 1
- How to set timeout on send?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from a2.