Giter VIP home page Giter VIP logo

Comments (4)

mszajna avatar mszajna commented on June 15, 2024

A bit of a me too, but I find the single value check questionable for any field, not just scalars, and had it get in the way before when I was trying to have the parent object take the form of a Datomic lookup ref like [:user/id "mszajna"].

I suppose the reason we need this check is that Clojure is really permissive and (= (get [] :field) nil) instead of exception. This is particularly annoying for default resolvers (everything just silently nils out), but in this particular case the check could be moved to the default resolver itself. In case of user-defined resolvers it should be easy enough for the developer to spot the problem imho.

from lacinia.

hlship avatar hlship commented on June 15, 2024

If this is a common problem, then it may be possible to defeat those checks with a schema compilation flag. It does mean that other programming errors will become harder to track down, but I think the problem of resolvers returning incorrect arity (single value vs. seq of values) is a minor one.

from lacinia.

hlship avatar hlship commented on June 15, 2024

I'm going to think about this for a bit first.

from lacinia.

hlship avatar hlship commented on June 15, 2024

The :disable-checks? schema compile option can be enabled (it is false by default); it removes the check that ensures that a single value is returned from a resolver that is not a list type.

This option was introduced for performance reasons, but should work well in your case, where a scalar type is, in fact, a seq or set. Of course, you'll need to provide :parse and :serialize for your scalar type that understands what to do.

from lacinia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.