Giter VIP home page Giter VIP logo

Comments (3)

warthog618 avatar warthog618 commented on July 20, 2024

I don't have time to look into this at the moment, so feel free to identify how the segmentation algorithm is wrong and provide a patch, or at least provide examples where it is encoded as 3 segments to highlight the difference.
Most likely the existing algorithm will not split multi-byte characters across segment boundaries, which I believe is the safer option, independent of whether that situation is covered in the spec. That would explain the behaviour you describe.

from sms.

mtryfoss avatar mtryfoss commented on July 20, 2024

Thanks for a quick feedback.

Debugging that part is a bit out of my knowledge. I just wanted to report back when we discovered a potential issue. We currently only use this module to calculate how many segments this is going to be when sending it through a provider (which handles all these details for us).

The feedback from that provider is one source saying that specific message should be possible to send as three messages. Another source is this web based debugger: https://messente.com/documentation/tools/sms-length-calculator

Skjermbilde 2021-12-14 kl  13 57 27

from sms.

warthog618 avatar warthog618 commented on July 20, 2024

Which shows the 2nd emoji being split across the segment boundary, as I suspected.
You should ask your provider to give you an API that returns the lengths they will generate.

from sms.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.