Comments (6)
@Martinsos what if we add something to the template UI (that they will obviously delete later) that alerts them to ignore the messages and explains the Dummy email provider + email signup process?
Otherwise, the docs do explain this in a couple different sections:
- https://docs.opensaas.sh/guides/authentication/#email-verified-auth
- https://docs.opensaas.sh/guides/email-sending/#the-dummy-email-provider-for-local-dev-only
But you are right, theSKIP_EMAIL_VERIFICATION_IN_DEV=true
var is set so theyre not being logged to the console (i probably changed this for e2e testing and forgot about the implications for the auth flow)
from open-saas.
I made this PR as a potential part of the solution: wasp-lang/wasp#2052 .
We can handle that one separately, as a bonus, and continue with the following in order to close this issue:
- Mention in the docs in an earlier place, probably right before they start playing with their newly created open-saas app and just after they created it, that Dummy provider behaves like this.
- remove
SKIP_EMAIL_VERIFICATION_IN_DEV=true
from template. But we need to set it for e2e tests.
Yeah, if we do these two, I would call this solved.
@vincanger I took a quick look but couldn't figure out the best place in e2e tests where to set this env variable for each test, what would you suggest?
from open-saas.
ok @Martinsos I added a section on the Dummy provider to the Auth section of the "Guided Tour".
SKIP_EMAIL_VERIFICATION_IN_DEV=true
has been removed from the template but remains in .github/workflows/e2e-tests.yml
so that it's available to the tests in the latest commit 2c94ced
from open-saas.
ok @Martinsos I added a section on the Dummy provider to the Auth section of the "Guided Tour".
SKIP_EMAIL_VERIFICATION_IN_DEV=true
has been removed from the template but remains in.github/workflows/e2e-tests.yml
so that it's available to the tests in the latest commit 2c94ced
Ok sweet! However a question: will e2e tests work locally then? Who sets that env var for them in that situation?
I am reopening issue to make sure we cover this question as it might be a potential problem.
from open-saas.
I tried to hunt down the commit in which you added the info about Dummy provider, I believe it is this one: 0c7f380 .
Change is looking good, although I personally hit the issue before I got to read this part of the doc, so this wouldn't really do it for me. The moment I was told to go explore the app, I started exploring the both online demo app and my local app, so I tried to sign up in my local app and hit the issue.
This is however connected also with how the whole "Guided Tour" is structured and that other issue we have on that, so maybe we can call this done on this front, and I will go into that issue and comment there that we need to make sure to mention the Dummy provider before they try to sign up into their app. Ok, done that here #152 (comment) .
from open-saas.
Ok, this leaves us with one thing left to resolve in this issue: do e2e tests work ok locally now, in the sense that the email verification is skipped? If yes, we can close it, if not, let's fix that.
from open-saas.
Related Issues (20)
- Ensure it is clear in the docs that email provider is not needed when using just Google OAuth
- In docs, ensure it is clear that Open-saas is a template based on Wasp the framework
- Improve "Guided Tour" page in the docs HOT 1
- Potentially improve the docs for file upload
- No stripe webhook trigger + cumulative subscription HOT 2
- update openAI sdk to latest version
- Add zod checks to social auth user fields getters
- setUsername.ts does more than the name says
- Drop (or modify) the suggestion to update your open-saas app HOT 1
- SendGris Issue HOT 1
- improve opensaas app_diff patching instructions for mac
- Consider gitignoring package-lock.json in template/app and opensaas-sh/app(_diff)
- type fileArgs -> rename to type FileDescription (in server/actions.ts)
- Avast says opensaas.sh is malicious! HOT 20
- SDK Build Error HOT 1
- e2e tests failing with cookie banner check HOT 1
- Stripe Integration, address and Name HOT 5
- 【feature request】lemon squeezy HOT 1
- deploy open-saas on Google Cloud Platform (firebase + cloud run) HOT 4
- deploy open-saas on AWS HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from open-saas.