onAuthSucceededRedirectTo value isn't respected when the user visits login route post successful auth about open-saas HOT 9 CLOSED

I'm rusty with my Haskell skills. I'll take a look to see if I can push a fix for this one.

Might even not need any, or very little haskell -> this is likely sometihng that will mostly need templates intervention. What might be hard is just getting the development flow to work for the first time, since the system is a bit complex, in some ways. But we would be happy to help! If you do want to give it a try, feel free to ask for any help in Discord regarding setup and similar. We tried to put a lot of info into waspc/README.md, but it might be confusing still.

from open-saas.

Great find @Case-E ! So this is not a bug in Wasp, but is actually a relatively unexpected behaviour that is part of OpenSaas, correct?

Let me move this issue to open-saas repo then and we can figure it out there.

Just to be clear, the behaviour you are suggesting is to remove this automatic redirecting of logged in users from /login to /. I agree, it seems to assume a bit too much. Better to have them stay on login and let devs impelment this redirect on their own if they want. Or, as you said, if we could reuse the value provided in onAuthSucceededRedirectTo. But I don't think we have an easy way to do that at the moment, and an option where they can redirect users on their own sounds completely fine.

Yeah, I would just vote for removing this history.push and that is it.

from open-saas.

Thanks @Case-E !

from open-saas.

I'm rusty with my Haskell skills. I'll take a look to see if I can push a fix for this one.

from open-saas.

I was looking in the Wasp code base and couldn't really find anything that would be causing this. So I looked in my code and realised the culprit was right there! 🤦

I copied the page over from OpenSaaS and didn't think to check it.

So removing that part, makes the login page load. We could probably make this an FR instead of a bug where the loginRoute could automatically redirect the user to onAuthSucceededRedirectTo or may be change it to a docs thing as this is something that devs can incorporate into their code.

from open-saas.

@vincanger what do you think?

from open-saas.

yep. I'll remove that now @Martinsos. Thanks for catching this @Case-E.

If you still wanna redirect logged in users, the best way is actually to do this:

import { Redirect } from 'react-router-dom';

export default function Login() {

  const { data: user } = useAuth();

  if (user) {
    return <Redirect to='/demo-app' />;
  }

from open-saas.

here is the PR for removing the redirect and creating a new diff for opensaas.sh #182

from open-saas.

Thanks @Martinsos and @vincanger! :D

from open-saas.