react-scripts ENOENT about discovery-nodejs HOT 6 CLOSED

Hi Coord,

I am having the exact same issue. What code changes did you make to run the demo? After I simply switch to "exec" from "spawn" and define "exec", it still fails. Appreciate if you could shed more light.

const exec = require('child_process').exec;

const client = exec('./node_modules/.bin/react-scripts', ['start'], {
  env: Object.assign({}, process.env, {
    REACT_APP_SERVER: 'http://localhost:5000',
  }),
  stdio: 'inherit',
});

Thanks
Lee

from discovery-nodejs.

Hi Lee,

Here is my updated start.js file:

const exec = require('child_process').exec;
const server = require('../server');

const client = exec(__dirname + '/../node_modules/.bin/react-scripts start', {
  env: Object.assign({}, process.env, {
    REACT_APP_SERVER: 'http://localhost:5000',
  })
}, (error, stdout, stderr) => {
  if (error) {
    // eslint-disable-next-line no-console
    console.log(`ERROR: ${error}`);
    killServer(() => {
      process.exit(1);
    });
    return;
  }
  console.log(`stdout: ${stdout}`);
  console.log(`stderr: ${stderr}`);
});

function killServer(callback) {
  const ppid = server.pid;
  const killer = exec('pkill -9 -P ' + ppid);

  killer.on('exit', () => {
    // eslint-disable-next-line no-console
    console.log(`PPID ${ppid} killed`);

    if (callback) {
      callback();
    }
  });
}

I also had to change one of the script commands in package.json to make it work correctly:

"build": "./node_modules/.bin/react-scripts build"

I did these changes relatively quickly, so it may be a little hacky. Let me know if you find a better solution :)

from discovery-nodejs.

Thank you, Coord,

from discovery-nodejs.

@maniax89 do you think you can take a look at this? @Coord sent me an email and I think this is one of the changes your team did to adopt create-react-app

from discovery-nodejs.

I have made a fix in #91 and it should work cross-platform now (sorry about that)

as for appending the ./node_modules/.bin -> I have removed this from all code as any script run with npm run supposedly adds the ./node_modules/.bin to the $PATH , thus we should never need to include it in scripts.

Let us know if you still have issues

from discovery-nodejs.

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from discovery-nodejs.