Comments (8)
Absolutely agree, good catch! Can you submit a PR with this fix?
Thanks,
milan
from datetime-fortran.
I don't know what PR means. Can you elaborate please? I think you might know Arjen Markus - you can ask him how good the NAG compiler is at catching bugs :-)
from datetime-fortran.
Can you please fork the repo, commit your changes to fix this in your repo, than submit a Pull Request (PR)? Thanks!
from datetime-fortran.
Hi Milan,
Yeah, sure. I can do it this weekend as I'm a bit tied up this week. Hope that's okay. I will run it past the NAG compiler with all error catching flags.
Cheers,
Wadud.
from datetime-fortran.
Hi Milan, I did a git clone
but was unable to create the configure
script:
$ ./mkdist.sh
Running mkdist.sh
Checking versioning consistency
configure.ac reports version: '1.6.1'
datetime.f90 reports version: ''
FAIL: Versions do not match. Aborting
from datetime-fortran.
Hi again Milan, could you please let me know the process of pull requests? Thanks.
from datetime-fortran.
Hi Wadud,
Sorry for the late response. If you git clone, run autoreconf -i
and this should generate the configure
script for you. Otherwise, you can also build using cmake (see the README).
For contributing, I recommend the following:
- Fork the repo. This will get you https://github.com/wadudmiah/datetime-fortran.
git clone https://github.com/wadudmiah/datetime-fortran
- Make your code changes locally. Make sure existing unit tests pass, and add unit tests if necessary.
- Commit and push to your forked repo on Github.
- Hit "New pull request" on your forked repo page on Github.
Thanks!
from datetime-fortran.
Hi Milan,
I have created the pull request. Please review the changes. The tests passed. By the way, in your INSTALL file, I would put the command "autoreconf -i" to create the configure script.
from datetime-fortran.
Related Issues (20)
- Document building with cmake and autotools HOT 1
- Define output (write) methods for datetime and timedelta instances HOT 1
- strptime does not handle errors HOT 1
- Cannot set seconds or others of timedelta HOT 3
- strptime does not zero tm struct before calling c_strptime HOT 1
- Error invoking datetime constructor with ifort-17.0.5 HOT 10
- Very strange (possibly compiler) bug with date2num HOT 3
- add support for mingw HOT 1
- Can't build tests on win-ifort. Fails on linker with strptime HOT 4
- "undefined reference" when using datetime-fortran HOT 7
- Building with autotools (not all libs are copied) HOT 9
- Dealing with huge timedelta values HOT 5
- Generic procedure including a sub-class of TimeDelta HOT 3
- Bug in function now() HOT 2
- Strptime Undefined Reference Error HOT 7
- Hour comparison in num2date is incorrect HOT 2
- Function that ingests ISO format and returns datetime? HOT 1
- CMake uses different compiler flags to autotools HOT 6
- Processing of `secondsSinceEpoch` and its reverse processing routine. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from datetime-fortran.