Giter VIP home page Giter VIP logo

Comments (8)

milancurcic avatar milancurcic commented on July 23, 2024

Absolutely agree, good catch! Can you submit a PR with this fix?

Thanks,
milan

from datetime-fortran.

wadudmiah avatar wadudmiah commented on July 23, 2024

I don't know what PR means. Can you elaborate please? I think you might know Arjen Markus - you can ask him how good the NAG compiler is at catching bugs :-)

from datetime-fortran.

milancurcic avatar milancurcic commented on July 23, 2024

Can you please fork the repo, commit your changes to fix this in your repo, than submit a Pull Request (PR)? Thanks!

from datetime-fortran.

wadudmiah avatar wadudmiah commented on July 23, 2024

Hi Milan,

Yeah, sure. I can do it this weekend as I'm a bit tied up this week. Hope that's okay. I will run it past the NAG compiler with all error catching flags.

Cheers,
Wadud.

from datetime-fortran.

wadudmiah avatar wadudmiah commented on July 23, 2024

Hi Milan, I did a git clone but was unable to create the configure script:

$ ./mkdist.sh 
Running mkdist.sh

Checking versioning consistency
configure.ac reports version: '1.6.1'
datetime.f90 reports version: ''
FAIL: Versions do not match. Aborting

from datetime-fortran.

wadudmiah avatar wadudmiah commented on July 23, 2024

Hi again Milan, could you please let me know the process of pull requests? Thanks.

from datetime-fortran.

milancurcic avatar milancurcic commented on July 23, 2024

Hi Wadud,

Sorry for the late response. If you git clone, run autoreconf -i and this should generate the configure script for you. Otherwise, you can also build using cmake (see the README).

For contributing, I recommend the following:

  1. Fork the repo. This will get you https://github.com/wadudmiah/datetime-fortran.
  2. git clone https://github.com/wadudmiah/datetime-fortran
  3. Make your code changes locally. Make sure existing unit tests pass, and add unit tests if necessary.
  4. Commit and push to your forked repo on Github.
  5. Hit "New pull request" on your forked repo page on Github.

Thanks!

from datetime-fortran.

wadudmiah avatar wadudmiah commented on July 23, 2024

Hi Milan,

I have created the pull request. Please review the changes. The tests passed. By the way, in your INSTALL file, I would put the command "autoreconf -i" to create the configure script.

from datetime-fortran.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.