incorrect literal with REAL64 kind about datetime-fortran HOT 8 CLOSED

Absolutely agree, good catch! Can you submit a PR with this fix?

Thanks,
milan

from datetime-fortran.

I don't know what PR means. Can you elaborate please? I think you might know Arjen Markus - you can ask him how good the NAG compiler is at catching bugs :-)

from datetime-fortran.

Can you please fork the repo, commit your changes to fix this in your repo, than submit a Pull Request (PR)? Thanks!

from datetime-fortran.

Hi Milan,

Yeah, sure. I can do it this weekend as I'm a bit tied up this week. Hope that's okay. I will run it past the NAG compiler with all error catching flags.

Cheers,
Wadud.

from datetime-fortran.

Hi Milan, I did a git clone but was unable to create the configure script:

$ ./mkdist.sh 
Running mkdist.sh

Checking versioning consistency
configure.ac reports version: '1.6.1'
datetime.f90 reports version: ''
FAIL: Versions do not match. Aborting

from datetime-fortran.

Hi again Milan, could you please let me know the process of pull requests? Thanks.

from datetime-fortran.

Hi Wadud,

Sorry for the late response. If you git clone, run autoreconf -i and this should generate the configure script for you. Otherwise, you can also build using cmake (see the README).

For contributing, I recommend the following:

1. Fork the repo. This will get you https://github.com/wadudmiah/datetime-fortran.
2. git clone https://github.com/wadudmiah/datetime-fortran
3. Make your code changes locally. Make sure existing unit tests pass, and add unit tests if necessary.
4. Commit and push to your forked repo on Github.
5. Hit "New pull request" on your forked repo page on Github.

Thanks!

from datetime-fortran.

Hi Milan,

I have created the pull request. Please review the changes. The tests passed. By the way, in your INSTALL file, I would put the command "autoreconf -i" to create the configure script.

from datetime-fortran.