Contribute with lock board plugin about react-flow HOT 7 CLOSED

Hey @raichuk

you should be able to create a PR from your fork via the web UI https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

from react-flow.

Hey @raichuk,

thanks for your kind words :)

I really like the idea of an interactive on/off button. You could integrate it in the controls plugin and add some options so that one could enable zoom/focus graph/interactive.

What do you think about that?

from react-flow.

Hi @moklick, thanks for this fast response.

You are right, the Controls plugin could integrate this change and the user would be able to enable it or not for later use.

I have some little things to check, but overall is done, so I can follow the process that you have for proposing a PR

Thanks.

from react-flow.

I think we need a contribution guide. Can you make a new branch from the develop branch? That would be perfect.

from react-flow.

Of course, I will commit there and when everything is done I will update you, so you don't need to start with the guide immediatly.

Thanks @moklick

from react-flow.

Hi @moklick.

I have everything ready, at least to check it when you have time.
I've branched from development branch and commited trying to follow the pattern that you use, but, of course, when trying to push my branch it returns me 403.

Do you want me to fork and create PR from my fork?

Thanks!

from react-flow.

@moklick PR is ready now, thanks for this opportunity!.

from react-flow.