State: nodes incorrectly positioned on rerender about react-flow HOT 11 CLOSED

@moklick thank you! great lib!

from react-flow.

amazing - it's all working great. thank you!

from react-flow.

You are right. We only check if there are changes in the data option of a node. I need to figure out how we can solve this.

from react-flow.

My 5 cents to this.
useElementUpdater should have dependencies on useEffects, like [elements]
also, it calling very often from parent on it's update.

from react-flow.

Hey @kinney

we are now also apply style and position changes to the nodes. I added a "change pos" button to the basic example https://react-flow-dev.netlify.app/basic

Could you check if the new version works for you?

Thanks @krizka we changed that!

from react-flow.

awesome - thank you!

the main issue is fixed. one related thing - if i zoom out and switch between positions, my tree similarly appears larger and less dense than it should. i realize this may be a different root cause (or maybe even intended behavior?). happy to create a new issue if you agree it's an issue. here's a slightly modified example that makes it easier to see:

https://gist.github.com/kinney/8df18b69a4c319936a800c145c2679ed

(+1 on great lib!)

from react-flow.

@kinney thanks for reporting this bug! It should be fixed in v1.3.5.

from react-flow.

Hey @kinney

we are now also apply style and position changes to the nodes. I added a "change pos" button to the basic example https://react-flow.netlify.app/basic

Could you check if the new version works for you?

Thanks @krizka we changed that!

Link not working

from react-flow.

Thanks @ashokslsk I updated the link

from react-flow.

Thanks @ashokslsk I updated the link

The link is not working again. Can you fix it please?

from react-flow.

this is the link: https://react-flow-dev.netlify.app/basic

from react-flow.