Comments (3)
Thanks @Tiketti! Perhaps I should have been more clear on what I meant. Looking at the linting code for Prettier, it seems that all commands are run using npm
. This is not too big of a deal for me personally, but I guess it wouldn't hurt to run the commands with the repo package manager instead.
What IS problematic for me is that the action runs these two linters (eslint and prettier) directly.
For monorepos, it is common to use a build system to handle caching. This requires setting up proxy commands like:
{
"scripts": {
"lint": "turbo run lint",
}
}
which handles caching of script outputs to reduce redundant command usage. The current lint-action behaviour does not allow for any custom commands like these. I suggest including a custom command argument that lets you specify what command to run in the repo. For example:
# ...
- name: Run linters
uses: wearerequired/lint-action@v2
with:
eslint: true
prettier: true
# example commands
eslint_command: "yarn lint"
prettier_command: "yarn format"
Or alternatively just let the linter arguments also accept a command instead of just a boolean value (don't know if GH actions allow for this):
# ...
- name: Run linters
uses: wearerequired/lint-action@v2
with:
eslint: "yarn lint"
prettier: "yarn format"
from lint-action.
While I agree that it would be great to have examples in documentation for pnpm
, too, I just modified the sample workflow a bit to for that use case. I hope you find it useful:
# ... the basic set up here
jobs:
run-linters:
name: Run linters
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: pnpm/action-setup@v2
with:
version: 8
- name: Use Node.js 20
uses: actions/setup-node@v3
with:
node-version: 20
cache: 'pnpm'
- name: Install dependencies
run: pnpm install
- name: Run linters
uses: wearerequired/lint-action@v2
with:
eslint: true
prettier: true
eslint_extensions: ts,tsx
from lint-action.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from lint-action.
Related Issues (20)
- Fails to create checkrun HOT 1
- Linters showing up under wrong workflow name HOT 1
- node12 is deprecated and will be forced to run on node16 error in github actions
- Rust linters both clippy and rustfmt are not recognized HOT 3
- Error when running on merge queue HOT 1
- Add support for mh_style HOT 1
- rubocop issue HOT 1
- Add support for Rome HOT 1
- "Validation failed" creating prettier checks HOT 7
- Action fails for "merge_group" events HOT 2
- ESLint with Flat Config breaks because of --ext parameter HOT 3
- TSC linter fails when no errors HOT 2
- ESlint config changes will change --ext usage HOT 3
- Checks annotation limit HOT 4
- ESlint config changes will change --ext usage
- lint only changed files HOT 1
- `clippy` and `rustfmt` are not _really_ supported HOT 7
- Clang_format only shows "code should be clang-formatted [-Wclang-format-violations]" HOT 1
- Add support for staticchecker HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lint-action.