Giter VIP home page Giter VIP logo

Comments (2)

h-a-n-a avatar h-a-n-a commented on May 28, 2024

Try to enable module in SWC js minifier plugin.

from rspack.

xc2 avatar xc2 commented on May 28, 2024

I've simplified the reproduction.

This problem occurs when importing a "module" package whose main file contains new URL("./", import.meta.url).

Both rspack and webpack will create an asset file xxx.js for the main file itself because of the statement new URL("./", import.meta.url) as documented: https://webpack.js.org/guides/asset-modules/#url-assets

Consider the foo example, the package foo has these two traits:

  1. there's new URL("./", import.meta.url) in foo/index.js
  2. is a "module" package

When importing foo, both rspack and webpack will

  1. bundle content of foo/index.js into the main asset file
  2. and also create an asset file xxxx.js whose content is same as foo/index.js

When minimizing the xxxx.js file, depending on the value of package "type"

package type of foo minimize rspack webpack
"module" ON [1]
"commonjs" ON [2] [2]
"module" OFF
"commonjs" OFF [2] [2]

After dig into it, I just found

  • failure [2] is dropped before minimizing which is as expected and has nothing to do with this issue.
  • while [1] is dropped on minimizing which causes this issue.
  • webpack minifies the file with module: undefined while rspack minifies it with module: false

from rspack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.