[Feature]: access to `compilation.assetsInfo` in `compilation.hooks.processAssets.tap` about rspack HOT 7 OPEN

If you are trying to append and access additional information to AssetInfo object across compilation stages, please use compilation.updateAsset to update assetInfo, compilation.getAsset or compilation.getAssets to retrieve assetInfo.

These getters and setters are necessary for bidirectional conversion between Js Object and their corresponding Rust structs under the hood. Otherwise, only knownAssetInfo will be persisted across compilation stages:

Let me know if this helped

from rspack.

This helped, thank you. I was able to move forward a little bit.

1) Do you know if there is a way to replace compilation.assets[ filePath ].source()?
I searched for updateAsset in the repo and found that there is also getAssetSource, but seems like it's internal only.

• rspack/crates/node_binding/binding.d.ts

  Line 26 in b05f523

  getAssetSource(name: string): JsCompatSource | null

• rspack/packages/rspack/src/Compilation.ts

  Line 978 in b05f523

  __internal__getAssetSource(filename: string): Source | void {

2) Also, I wasn't able to confirm this fully, because I'm getting Process finished with exit code -1073741571 (0xC00000FD) (stack overflow?).
I understand this is probably not related, but may be you know what may be causing this?

from rspack.

1. Do you know if there is a way to replace compilation.assets[ filePath ].source()? I searched for updateAsset in the repo and found that there is also getAssetSource, but seems like it's internal only.

• rspack/crates/node_binding/binding.d.ts

  Line 26 in b05f523

  getAssetSource(name: string): JsCompatSource | null

• rspack/packages/rspack/src/Compilation.ts

  Line 978 in b05f523

  __internal__getAssetSource(filename: string): Source | void {

Calling compilation.getAsset(<name>) or compilation.getAssets() gives you Asset object with source

	getAssets(): ReadonlyArray<Asset> {
		const assets = this.#inner.getAssets();

		return assets.map(asset => {
			return Object.defineProperties(asset, {
				info: {
					value: JsAssetInfo.__from_binding(asset.info)
				},
				source: {
					get: () => this.__internal__getAssetSource(asset.name)
				}
			}) as unknown as Asset;
		});
	}

from rspack.

2. Also, I wasn't able to confirm this fully, because I'm getting Process finished with exit code -1073741571 (0xC00000FD) (stack overflow?). I understand this is probably not related, but may be you know what may be causing this?

I am not sure what it means. Can you create a minimal reproduction that triggers this error?

from rspack.

1. Do you know if there is a way to replace compilation.assets[ filePath ].source()? I searched for updateAsset in the repo and found that there is also getAssetSource, but seems like it's internal only.

• rspack/crates/node_binding/binding.d.ts

  Line 26 in b05f523

  getAssetSource(name: string): JsCompatSource | null

• rspack/packages/rspack/src/Compilation.ts

  Line 978 in b05f523

  __internal__getAssetSource(filename: string): Source | void {

Calling compilation.getAsset(<name>) or compilation.getAssets() gives you Asset object with source

	getAssets(): ReadonlyArray<Asset> {
		const assets = this.#inner.getAssets();

		return assets.map(asset => {
			return Object.defineProperties(asset, {
				info: {
					value: JsAssetInfo.__from_binding(asset.info)
				},
				source: {
					get: () => this.__internal__getAssetSource(asset.name)
				}
			}) as unknown as Asset;
		});
	}

One custom plugin emits a new asset with:

const fileContents = JSON.stringify( fileListJson );

compilation.emitAsset( fullPath, new compiler.webpack.sources.RawSource( fileContents ) );

And in another custom plugin I tried:

compilation.getAsset( filePath ).source(); // didn't work
compilation.getAsset( filePath ).source.get(); // didn't work
compilation.getAsset( filePath ).source.toString(); // didn't work

Only this worked, but seems like it's a band-aid:

const fileMapSource = compilation.getAsset( filePath ).source._valueAsString; // did work

Its usage is:

const fileMap = JSON.parse( fileMapSource );

I'm on v1.0.0-alpha.2 now.

from rspack.

Is there access to compilation.valueCacheVersions?

I only found this:

• https://github.com/search?q=repo%3Aweb-infra-dev%2Frspack+valueCacheVersions&type=code
• https://github.com/search?q=repo%3Aweb-infra-dev%2Frspack+value_Cache_Versions&type=code

My usage in the same custom plugin:

const foundAsset = findAsset( pathInMap, compilation.assetsInfo );

if ( foundAsset ) {
    let assetPathPrefix = '';

    for ( const [ key, value ] of compilation.valueCacheVersions ) {
        // @todo Find less error-prone way.
        if ( key.includes( 'webpack/DefinePlugin process.env.ASSET_PATH' ) ) {
            assetPathPrefix = value
                // “/” gets (re)added later
                // @todo This is all dirty. Find a better way.
                .replace( '/', '' )
                .replace( /"/gu, '' );
        }
    }

    filePath = `${ assetPathPrefix }${ foundAsset }`;
}

from rspack.

And in another custom plugin I tried:

compilation.getAsset( filePath ).source(); // didn't work
compilation.getAsset( filePath ).source.get(); // didn't work
compilation.getAsset( filePath ).source.toString(); // didn't work

Only this worked, but seems like it's a band-aid:

const fileMapSource = compilation.getAsset( filePath ).source._valueAsString; // did work

You were using the wrong API. Check out webpack-sources.

from rspack.