Giter VIP home page Giter VIP logo

Comments (4)

cbbfcd avatar cbbfcd commented on September 27, 2024 1

@hardfist Certainly, I need to confirm that the expectation is to add a configuration that by default does not process comments, but also allows this configuration to be turned off (maintaining the current logic of processing all comments).

from rspack.

hardfist avatar hardfist commented on September 27, 2024

seems a bug of dojang, since you spot the problem are you willing to fix it

from rspack.

cbbfcd avatar cbbfcd commented on September 27, 2024

I tried to understand the implementation mechanism of the html-webpack-plugin and found that it has similar issues. The template engine might not handle comments and directly process variables. In this case, you can solve the problem through templateParams. Therefore, in terms of aligning with the capabilities of the html-webpack-plugin, the current html-plugin of Rspack seems reasonable and not a bug.

If modifications are needed, it would also be reasonable because the commented-out code should not have any actual code significance and does not need to process variables. This would require changes to the dojang crate, but it seems I didn't find where to modify this crate.

In conclusion, this seems to be a non-essential modification.

from rspack.

hardfist avatar hardfist commented on September 27, 2024

thanks for investigation, then we keep it as it is

from rspack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.