Comments (1)
shekohex
commented on August 14, 2024
1
While I do agree that the encode_resource_id implementation is not correct, and should be the same as we do it in the EVM. I would suggest being as the following:
- Encoding: Big Endian.
TreeId(mostly 4 Bytes) and should be left padded with zeros to fill the remaining 20 bytes to adhere to aContractAddress(20 bytes).ChainId(should be 4 bytes) and it should be placed as the lastxbytes (depending on its size, which we should agree on).
So the diagram in the comments is mostly correct, but the comments said it is Little Endian, which is not correct as we found out that EVM is using Big Endian, everywhere.
from protocol-substrate.
Related Issues (20)
- [TASK] Add slack to nonces to allow them to increment at most 1024. HOT 1
- [TASK] Add Set Resource with signature to SignatureBridge Pallet
- [Issue] Fix Doc CI
- [CHECKLIST] Tracking issue for failing benchmarks HOT 2
- [TASK] Register and transact on VAnchor similar to protocol-solidity HOT 1
- [TASK] Skip Chain Id validation while chain whitelisting and update set_resource method in handlers
- [Issue] docker image-publish job fails
- Unable to use vAnchor deployments done in genesis HOT 1
- [TASK] Finish transactWrap/Unwrap flow with new token parameter on ExtData HOT 1
- [TASK] Add wrapAndDeposit combined flow on VAnchor. HOT 1
- Depreciation warnings HOT 1
- [TASK] Asset Registration Pallet
- [SPEC] Asset Registration Pallet
- [TASK] Anonymity Mining Claims Pallet
- [TASK] Update set maintainer to take nonce as input HOT 2
- [TASK] Fix CI to publish types and publish the package on npm HOT 1
- [TASK] Benchmark Claims Pallet
- [TASK] Update benchmarks for all pallets
- [TASK] Add rpc api for is_known_root method HOT 1
- [BUG] Ensure token-wrapper fee recipient has existential deposit HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protocol-substrate.