Comments (13)
M317
- M 317 Sk4 T. 3B-6:
- doubled svgGroupId "g10030" for m. 6, sys. 3-4, and m. 6, sys. 4 ("fis1 durch Einkreisung getilgt"), probably wrong in second case
- M 317 Sk4 T. 7-12:
- Missing tkk entry for tkk-group m. 12, sys. 8: [xx] ? Or too many classes? (order of svg elements)
- M 317 Sk4 T. 13-15:
- Missing tkk entry for tkk-group m. 13, sys. 15,16: rests ? Or too many classes? (order of svg elements)
- Missing tkk entry for tkk-group m. 14, sys. 16: [xx] ? Or too many classes? (order of svg elements)
- M317 Sk3.1.3:
- Linkbox grouping for all link boxes missing?
- In SVGs, this sketch includes system 5 (because of the "Strich mit unklarer Bedeutung."). Sys, 5 not declared in SourceDescription.
- M317 Sk3.1:
- Nested tkk groups g1225 in g1241 works, but will not be rendered properly
- Linkbox grouping for Sk1 missing
- Link to C:Sk1 not correct (in comment for m. {5}, sys. 4, 6/8)
- M317 Sk3.1.2:
- Linkbox grouping for Sk1 missing
- M317 Sk1:
- Linkbox grouping for Sk2.1.3 missing
from awg-app.
M 317 Sk 4, Missing tkk entry for tkk-group m. 14, sys. 16:
##looks fine to me. what is wrong?
M317 Sk3.1, Link to C:Sk1 not correct (in comment for m. {5}, sys. 4, 6/8):
##looks fine to me, what is wrong?
M317 Sk3.1.3, Linkbox grouping for all link boxes missing?:
##big mystery... grouping exists, sth is wrong anyway.
for the other findings in M317 see PR #852
from awg-app.
M 317 Sk 4, Missing tkk entry for tkk-group m. 14, sys. 16:
##looks fine to me. what is wrong?
The SVG viewer displays a tkk-box for "u. von u. 3 sowie Winkel mit rotem Buntstift." which is correct, but another (smaller) tkk-box inside it around the "u. 3". But there is no separate tkk for that location. So wether the tkk comment is missing or there is an additional misplaced tkk-class in the SVG file.
M317 Sk3.1, Link to C:Sk1 not correct (in comment for m. {5}, sys. 4, 6/8):
##looks fine to me, what is wrong?
Yes, seems to be fine for me, too. Probably there was some issue before the latest release, but it seems to be gone.
from awg-app.
I see. M 317 Sk4 should be fixed now (update PR #852).
from awg-app.
M317 Sk3.1.3, Linkbox grouping for all link boxes missing?:
##big mystery... grouping exists, sth is wrong anyway.
just a guess: this is the only item so far with linkbox grouping + "rowtable": true,
might this cause the issue?
from awg-app.
I don't think so. But I recognized that in other files there is a group with an aria-label for the linkBox label within the g.link-box
, something like:
<g
aria-label="Sk2.1"
id="text110"
style="font-weight: 700; font-size: 12px; font-family: Arial-BoldMT, Arial; isolation: isolate; fill: #7d7d7d;"
class="cls-13"> ...
This is missing for all link-boxes in Sk3.1.3
from awg-app.
M30 & M34
-
M 34 Sk 1
- Missing svgGroupId (and class in svg?) for m. 1, sys. 2, 3/4: Viertelnote gestrichen
-
M 30 Sk1
-
T. {9D-12B}
- m.
{9D-12B}
in SVG vs. m.{9D–10D, 11B}, 12B
in sourceDesc
- m.
-
T. 7B -{10C}:
-
Des
(?) in: {
"svgGroupId": "g1156",
"measure": "9C",
"system": "11",
"position": "1. Note",
"comment": "des
gestrichen."
},
-
-
T. 9E-{15B}
-
{13B–15B}
(?) in: {
"svgGroupId": "g1197",
"measure": "{13B–14B}
",
"system": "14–15",
"position": "",
"comment": "Takte pauschal gestrichen."
},
-
-
T. 17–21
-
[b]b2 ... [a]g2
(?) in: {
"svgGroupId": "g1131",
"measure": "19",
"system": "1",
"position": "6/8",
"comment": "b
2 überschreibtg
2."
},
-
-
T. 25–29B
-
[a]a1 ... [b]ges1
(?) in: {
"svgGroupId": "g1108",
"measure": "27",
"system": "7",
"position": "4. Note",
"comment": "a
1 überschreibtge
s1."
}, - class and groupId in SVG missing for {
"svgGroupId": "g37",
"measure": "{28A–29A}",
"system": "7",
"position": "",
"comment": "Noten pauschal gestrichen."
},
-
-
from awg-app.
M212 TF 1
-
p. 1
- The first tkk in m.1 has as location:
(2/8) bis Taktende
for the hairpin, but the crescendo hairpin ends at 2/4 ?
- The first tkk in m.1 has as location:
-
p. 2
- The tkk for m. 14, 1/8, and (now) m. 14 1/8 (but probably m. 23, see below) dispaly accidentals in brackets. Correct? //TA: correct!
- There is no tkk displayed on the very last asterisk m. 23, but a second tkk displayed in m. 14, lower piano, that reads:
14 | Klav. | 1/8 | (♯) zu Gis1/Cis und (♮) zu H/g als redundant weggelassen. B: Akkoladenwechsel nach T. 22.
which is probably the missing tkk for m. 23?
-
SourceDescription:
- Description mixes
Flecke
andFlecken
for plural forms. - FirmSign mentioned, but no image/type included?
-
Die Korrekturen in <strong>B</strong>B betreffen Textfassung 2.
Probably without the repeatedB
? (ping @masthom since added after your PR) - Wouldn't add a line break in the title description
- Description mixes
line breaks also in op. 25 source A (Taktzahlen, Instrumentenvorsatz)!?
for the other points see #910
- Tkk class and group id missing for
"svgGroupId": "",
"measure": "18",
"system": "Ges.",
"position": "1. Note",
"comment": "Text sic: (Ver-)storb(-nen) ohne Binnen-Apostroph. Rosegger_PM: Verstorb’nen."
},
from awg-app.
Op. 22 SkRT
-
SourceDescription:
- Writing Material mentions 3 types of sheets, but refers only to "Bl. 1" and "Bl. 2"
- Also: correct that the "shortest" sheet type has 9 systems, and the longer ones have only 8 systems?
-
SkRTc
- Last tkk on row variant 47 had:
Bl. 3r | 8a | Ub
. Corrected toUd
according to SourceDescription and transcription, correct?
- Last tkk on row variant 47 had:
from awg-app.
Op. 27 SkRT
-
SkRTa:
- Row form Ges should be Kgis (?) in
Bl. 1r | 1b | Ges: 10.–11. Reihenton | Auf Rasur: vermutlich ♭b1–♮h1 geändert zu ♭b–♮h.
- Row form Ges should be Kgis (?) in
-
SkRTb:
- Tkk for second dividing line is missing (but duplicates svg id and content of that in SkRTa = C&P error?):
Bl. 2r | 1b–8b | K- und KU-Formen: 6.–7. Reihenton | Strich zur Gliederung der Hexachorde mit rotem Buntstift. Vermutlich nachträglich gezogen, da der Strich mit einzelnen Notenköpfen kollidiert.
- Kd should be Ka (?) in
Bl. 2r | 1b | Kd | Reihennummerierung 18 mit grünem Buntstift.
- Tkk for second dividing line is missing (but duplicates svg id and content of that in SkRTa = C&P error?):
from awg-app.
Related Issues (20)
- [TEST] Improve Unit Test Speed HOT 1
- Contributors HOT 12
- [EDITION] Textcritical comments for op. 25 Sk4 are not complete yet
- [EDITION] Reload Convolute view when clicking on side navigation
- Ideas & interesting tools
- [EDITION] Self-reflexive graph properties not correctly calculated? HOT 4
- [EDITION] ReferenceError in EditionGraphModule HOT 4
- [EDITION/GRAPH] Problems using a touchpad HOT 4
- Deprecated sketch sigla in modal snippets HOT 2
- Zoom function for SVGs HOT 1
- [BUILD] Use automated dependency updates HOT 1
- Remove B from op. 25 modal
- Sticky side menu with scrollspy
- Add StorageService HOT 1
- Get SVG paths for link boxes and link them to sketches HOT 1
- Source description measure HOT 1
- Include Routes for Series and Sections HOT 1
- Differentiate textcritics according to edition type
- Add text sources to source description
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from awg-app.