Comments (3)
Sure. I just saw a number of people in the issues seemingly doing suboptimal things. And actually I believe that adding support would, say, bring the score down. Because people wouldn't have to think about what to do with host key verification.
About autoadding BitBucket, GitLab, you-name-it keys, I didn't mean exactly that. In your place I would probably not autoadd them automatically, I'd let the users decide, like:
- uses: webfactory/[email protected]
with:
ssh-private-key: ${{ secrets.SSH_PRIVATE_KEY }}
host-keys:
- GitHub
- GitLab
- BitBucket
- 'example.com,xx.xxx.xx.xxx ssh-rsa AAAA...kMIR some-name'
Similar to what the nodemailer
guys did. Or that all indeed might be extracted into a separate action.
But again. Feel free to close the issue. But in that case I'd probably add more specific instructions to the readme (examples). One for third-party servers. In this case one should probably rely only on domains. And for in-house ones. In this case I think it makes sense to provide an ip as well.
from ssh-agent.
I would really like to keep this action focused and the scope narrow; and since adding the key is a one-liner (as you suggested), I don't see much added value in having it supported in the action.
Regarding the GH Host Key, you're right that this is a special case. I thought it would help a lot of people since in the beginning, the worker nodes did not come with this key by default. GitHub has changed this in the meantime, but I never though about when/how to best drop this particular key.
If you thought about bringing along some more host keys in the action (i. e. not as user-provided keys), please understand that I would neither have a good policy how to select them (GitHub? BitBucket? GitLab? What else, what not?) and/or to make sure the keys are and will stay up to date and correct.
Does that make sense?
from ssh-agent.
I'd be glad if you could open a PR to add some remarks regarding Host Keys in the README.
I will be unable to maintain (and guarantee accuracy) for pre-defined host keys in this action, and so something like what you suggested in your example config above seems unfeasible for me.
Again, thank you for your understanding, and looking forward to your PR!
from ssh-agent.
Related Issues (20)
- Doesn't work for self-hosted runners that are nobodies (no `passwd` entry) HOT 4
- Keys not properly loaded when calling the action multiple times
- Possibility of sar node 18 and equivalent npm
- Public Key Printed Out Even With log-public-key set to false HOT 4
- ERROR: stat "": no such file or directory
- Enable custom github server HOT 1
- Can't get it to work – Permission denied HOT 1
- Update to node20 HOT 2
- Windows workflow fails with "Could not read from remote repository" HOT 5
- `no such identity` on self-hosted Linux Github runner HOT 2
- After update to 0.9.0: The ssh-private-key argument is empty ... HOT 9
- Post cleanup fails HOT 2
- Error: Command failed: ssh-add - HOT 1
- Error: does not match GitHub URL pattern. Not treating it as a GitHub deploy key on version 0.9.0 HOT 8
- changelog out of date HOT 1
- Documentation about how to set up self-hosted runners HOT 4
- When upgrading from 0.7.0 to 0.8.0, functionality breaks HOT 2
- add ssh key for host?
- Is there a way to setup this without having a key specified?
- 'Support for GitHub deploy keys' breaks local CI for repositories which are submodules of other repositories which use ssh-agent with local CI
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ssh-agent.