Update https://docs.webiny.com/docs/webiny-apps/security/development/app/components/ about docs.webiny.com HOT 9 CLOSED

That would be nice 👍

from docs.webiny.com.

Not sure what you were aiming at here but both components are very necessary. 🙂

from docs.webiny.com.

Actually it was me aiming at it :D Those components are 90% the same, so I was wondering if we can get away with making it into 1 component. If it's really necessary to have 2 components, let's leave it as is.

But, do we need to have roles prop?

from docs.webiny.com.

Roles - no.

Those are completely removed, only scopes are relevant now.

from docs.webiny.com.

Regarding components, if you ask me, I would leave it.

SecureRoute, as you've probably seen, will render a not-authorized error message, which can be customized via a plugin. With it, you only wrap the route, and fallback render happens automatically, no need to handle it for every route with own code.

And SecureView is just for rendering/not-rendering parts of the UI (so by default, there is no fallback render). We use it in menus components for example, to render/not-render menu items accordingly.

from docs.webiny.com.

BTW guys, there is this PR that removes usage of roles prop in the docs articles:

#31

I can merge into next branch.

from docs.webiny.com.

Although, I noticed a few things here that are incorrect (didn't do a review after final changes were made).

Anyways, I'll take a look and merge it.

from docs.webiny.com.

ℹ️ Merged (next branch) and fixed content in the following articles:

• /docs/webiny-apps/security/development/app/components/secure-view
• /docs/webiny-apps/security/development/app/components/secure-route
• /docs/webiny-apps/security/development/api/graphql-helpers/has-scope

from docs.webiny.com.

Adrian already resolved this issue, so I'll close this.

from docs.webiny.com.