Giter VIP home page Giter VIP logo

Comments (2)

sairion avatar sairion commented on May 30, 2024

Hello! Thanks for suggestion. I'm thinking of just remove default class, move the component to diffrent package, and leave the component here for compatibility-wise reason (with console message to suggest migration).

Before it happens, you can pass 'defaultClassName' prop to remove the default icon-svg class. If you find it awful to do it all over the place, you can wrap it with wrapper component like:

class IconSVG2 extends Component {
    render () {
         return <IconSVG defaultClassName="" src={...} />
    }
}

Thanks for report!

from svg-inline-loader.

sairion avatar sairion commented on May 30, 2024

I removed defaultClassName from newly packaged component: https://github.com/sairion/svg-inline-react

and IconSVG component is deprecated in this package.

from svg-inline-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.