Comments (8)
@Kinrany no, we use pure javascript for better maintenance projects, somebody can use flow
, somebody typescript
, somebody other, we use typescript
comments for check types
from tapable.
Do you need any help? I am interested in writing typescript. 😃
from tapable.
By all means I'll close this PR and you can take a crack at it.
from tapable.
Sorry @TheLarkInn , I didn't see your PR. I thought it's just the discussion phase.
No need to close your PR.
from tapable.
No it's not a problem at all. Infact there were a few things I was struggling with (that are TS limitations for some of our functions which take a callback as the last argument). If you would like to take some time to investigate converting this over I would love to see this. Also you can use the existing tests to ensure your TS changes are valid when compiled.
from tapable.
Hi @TheLarkInn ,
I've been struggling with this in the past few days. Because converting it to typescript without breaking it is rather simple. But make it more extendable is a totally different work. Also I think the callback style is not great for reading/maintaining perspective. Then I realised that the problem is I don't know the expectations.
So what's the purpose of this initiative? Is it simply converting to typescript, adding type annotation? Or we can use this to make it better? e.g: use promise instead of callback like suggested in #11 ?
I think it needs some directions from the core team to clarify on this. Thanks!
from tapable.
The main goal for now would be to convert it to Typescript and add types. But in a way in which it would prevent the existing tests and APIs from not breaking.
I agree that this could be more extensible but for now I want to have it in a working state.
from tapable.
Typescript's types improved a lot in the past two years. Any plans to reopen this issue?
from tapable.
Related Issues (20)
- Re-order taps after tap function is called to guarantee old taps are in correct order HOT 3
- what is the idea of reassignment a class propery
- AsyncParallelBailHook, I use tapAsync/callAsync, it doesn't work as expected HOT 3
- DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead HOT 2
- Not compatible with webpack v5 HOT 1
- Why hooks constructor can not use arguments like readme.md said HOT 1
- has `hooks.hookName.taps` been not recommanded? HOT 3
- i use tapable singlely in my project,but in my webpack,"node_modules" folders has no compile. HOT 4
- AsyncHook in types HOT 6
- May I ask some question?
- Is the new Function performance really good? HOT 13
- Is it a BUG? callback of tapAsync not work in AsyncSeriesLoopHook HOT 2
- is there an way to intercept waterfall hook result ?
- Why not put _resetCompilation in this.call HOT 1
- .tap() `before` parameter do not respects existing befores HOT 1
- TS Error HOT 3
- `context` property for interceptor is un-typed
- Re-order hooks
- [Bug] Async hook doesn't catch error when reject a falsy value HOT 6
- Facing TypeError: Cannot read properties of undefined (reading 'tap') HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tapable.