Migrate to Typescript about tapable HOT 8 CLOSED

@Kinrany no, we use pure javascript for better maintenance projects, somebody can use flow, somebody typescript, somebody other, we use typescript comments for check types

from tapable.

Do you need any help? I am interested in writing typescript. 😃

from tapable.

By all means I'll close this PR and you can take a crack at it.

from tapable.

Sorry @TheLarkInn , I didn't see your PR. I thought it's just the discussion phase.

No need to close your PR.

from tapable.

No it's not a problem at all. Infact there were a few things I was struggling with (that are TS limitations for some of our functions which take a callback as the last argument). If you would like to take some time to investigate converting this over I would love to see this. Also you can use the existing tests to ensure your TS changes are valid when compiled.

from tapable.

Hi @TheLarkInn ,

I've been struggling with this in the past few days. Because converting it to typescript without breaking it is rather simple. But make it more extendable is a totally different work. Also I think the callback style is not great for reading/maintaining perspective. Then I realised that the problem is I don't know the expectations.

So what's the purpose of this initiative? Is it simply converting to typescript, adding type annotation? Or we can use this to make it better? e.g: use promise instead of callback like suggested in #11 ?

I think it needs some directions from the core team to clarify on this. Thanks!

from tapable.

The main goal for now would be to convert it to Typescript and add types. But in a way in which it would prevent the existing tests and APIs from not breaking.

I agree that this could be more extensible but for now I want to have it in a working state.

from tapable.

Typescript's types improved a lot in the past two years. Any plans to reopen this issue?

from tapable.