Giter VIP home page Giter VIP logo

Comments (3)

emma-sg avatar emma-sg commented on August 27, 2024 2

Backend/DB todos

  • Set InvitePending#created in backend explicitly, rather than relying on frontend
  • Implement TTL check from InvitePending#created field on every invite access/get

For initial user re-invites

  • Endpoint to re-create an invite from an existing invite (only if org for original invite has zero users)
  • Add "initial user"/"can re-create expired invites" boolean to endpoints used on initial render of invite accept page

For multi-user orgs

  • Endpoint to get expired invites
  • Endpoint to recreate existing invite using admin auth

from browsertrix.

ikreymer avatar ikreymer commented on August 27, 2024 1

For clarity, closing this issue in favor of #1912 which provides additional details on improvements + bug.

from browsertrix.

ikreymer avatar ikreymer commented on August 27, 2024

[ ] Set InvitePending#created in backend explicitly, rather than relying on frontend
[ ] Implement TTL check from InvitePending#created field on every invite access/get

This is already set on https://github.com/webrecorder/browsertrix/blob/main/backend/btrixcloud/invites.py#L198
There is also an expiring index so that the invites auto-expire: https://github.com/webrecorder/browsertrix/blob/main/backend/btrixcloud/invites.py#L54

  • Users who miss their invite should be taken to a page telling them their invite expired and to contact their org admin

  • Admins should see a list of invitations that have expired in the members panel alongside pending and users

    • Expired invites table should list emails, the expiry date, and the role they were to be given (as a dropdown).
    • Expired invites table should have two actions, one to delete the invite and another to resend it.

This isn't something that we need at this point, as the invite system is something that is used fairly rarely.

We just want to improve the error message, so if an invite is invalid, we should just say something like: 'This invite is not valid. If you've received this invite a while ago, it may have expired. If you believe this may have happened. Please contact support / your Browsertrix Admin to request a new invite'

I think that's the extent of what we should do now to address this issue.

from browsertrix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.