Giter VIP home page Giter VIP logo

Comments (6)

ikreymer avatar ikreymer commented on June 17, 2024

Implemented /artifacts/upload/<id> only, the others are less urgent as they're not linked to directly.

from browsertrix.

Shrinks99 avatar Shrinks99 commented on June 17, 2024

See #922 for determining what things should be named

from browsertrix.

ikreymer avatar ikreymer commented on June 17, 2024

Awaiting final decision on the name

from browsertrix.

SuaYoo avatar SuaYoo commented on June 17, 2024

@ikreymer Do we still want separate subpaths for crawltype, like /artifacts/uploads and /artifacts/upload/{id}? I see some benefit to standardizing around a single subpath and using query params to filter the view for streamlining, now that the API endpoint all-crawls returns the same data shape as uploads and crawls.

Thoughts on the following:

  • All Archived Items:/orgs/{oid}/archive/items
  • Crawls:/orgs/{oid}/archive/items&type=crawl
  • Uploads:/orgs/{oid}/archive/items&type=upload
  • Any Archived Item detail: /orgs/{oid}/archive/items/{id}

from browsertrix.

ikreymer avatar ikreymer commented on June 17, 2024

@ikreymer Do we still want separate subpaths for crawltype, like /artifacts/uploads and /artifacts/upload/{id}? I see some benefit to standardizing around a single subpath and using query params to filter the view for streamlining, now that the API endpoint all-crawls returns the same data shape as uploads and crawls.

Yes, I think the old 'artifact' name no longer makes sense.

Thoughts on the following:

  • All Archived Items:/orgs/{oid}/archive/items
  • Crawls:/orgs/{oid}/archive/items&type=crawl
  • Uploads:/orgs/{oid}/archive/items&type=upload

I think that makes sense.

  • Any Archived Item detail: /orgs/{oid}/archive/items/{id}

For the details, I think the type specific endpoint might be better since we can include type-specific info in the detail?
Also, ArchiveWeb.page currently uses the /artifacts/upload/<upload-id> but I guess we should probably add a redirect regardless

from browsertrix.

SuaYoo avatar SuaYoo commented on June 17, 2024

Closed by #1064

from browsertrix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.