node is not instanceof HTMLElement when imported from uhtml v3 about uhtml HOT 7 CLOSED

It was a uparser issue which has now been fixed (and covered).

Apologies for the inconvenient.

from uhtml.

We ran into the same issue. The html.node function does not return an HTMLElement instance in our codebase when we import it from NPM and bundle it with webpack. However, if we load the package from a CDN, it does. The version is 3.0.0 in both cases.

from uhtml.

We did a little more deep-dive:
It seems like, that if the template for the html.node function starts with an empty line it will return a #document-fragment instead of an HTMLElement.

Please check out this code to reproduce:

import { html } from "https://cdn.jsdelivr.net/npm/[email protected]/esm.js";

const elementA = html.node`<div>foo</div>`;
const elementB = html.node`
  <div>bar</div>
`;

console.log(elementA instanceof HTMLElement);
console.log(elementB instanceof HTMLElement);

from uhtml.

It has nothing to do with importing from NPM or a CDN, it's just that we had a different template in our production code.

from uhtml.

I can confirm this. I just double checked my production code.

Unfortunately we use the empty line a lot at the beginning of tagged templates. Following syntax is quite common in our project:

      mapp.utils.render(mapview.attribution.target,
        mapp.utils.html`${Object.entries(o)
          .map(entry => mapp.utils.html`
              <a class="background-fade" target="_blank" href="${entry[1]}">${entry[0]}`)}`)

from uhtml.

Thanks for the quick fix, @WebReflection <3

from uhtml.

So … the bug is about code that works as expected? I’ve no idea how to help here.

The parser is different and it might be the culprit … try older uparser with uhtml 3 or just stick with uhtml 2 until you understand what’s failing and how I can reproduce it?

from uhtml.