Comments (10)
My recent PRs resolve all but six stale link targets. The remainder may have valuable replacement targets that I'm unable to identify. Someone more knowledgeable should take a look. Remaining 404s:
- ./_site/faq/index.html
* External link https://chromium.googlesource.com/external/webrtc/+/master/webrtc/video_engine/include/vie_render.h failed: 404 No error
- ./_site/native-code/android/index.html
* External link https://chromium.googlesource.com/external/webrtc/+/master/webrtc/api/java/README failed: 404 No error
- ./_site/native-code/native-apis/index.html
* External link https://chromium.googlesource.com/external/webrtc/+/master/webrtc/api/peerconnection.h failed: 404 No error
- ./_site/start/index.html
* External link http://hu.tt failed: 404 No error
* External link https://plus.sandbox.google.com/113817074606039822053/posts failed: 404 No error
- ./_site/testing/conformance/index.html
* External link http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29 failed: 404 No error
from webrtc-org.
Wow. This is awesome. Thanks @louquillio! I could try the first 3. For instance, peerconnection.h
is here: https://chromium.googlesource.com/external/webrtc/+/master/webrtc/pc/peerconnection.h
from webrtc-org.
Adding @hkjellander and @KaptenJansson for some hints on these links.
I am not 100% sure about peerconnection.h
. It could also be https://chromium.googlesource.com/external/webrtc/+/master/webrtc/api/peerconnectioninterface.h.
The /api/java/README
could be https://chromium.googlesource.com/external/webrtc/+/master/webrtc/sdk/android/README.
I have no ideas about: vie_render.h
, http://hu.tt failed and https://plus.sandbox.google.com/113817074606039822053/posts, but I think we can remove them.
Also no idea about the conformance
link.
from webrtc-org.
Both the peerconnection.h and mediastream.h links should be replaced with: https://chromium.googlesource.com/external/webrtc/+/master/webrtc/api/peerconnectioninterface.h and https://chromium.googlesource.com/external/webrtc/+/master/webrtc/api/mediastreaminterface.h since we only want to point at public (and supported) APIs.
/api/java/README could be https://chromium.googlesource.com/external/webrtc/+/master/webrtc/sdk/android/README.
That's correct
vie_render.h
Remove; it was deleted back in https://webrtc-codereview.appspot.com/55379004
hu.tt
Just remove, it seems to be some old name of a Citrix product (not sure what it might have been replaced with). https://news.ycombinator.com/item?id=6682853
Just remove if it can't be found. Dunno what it could have been.
conformance page
The http://www.chromium.org/blink/importing-the-w3c-tests link should be replaced with https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
Let's just remove the outdated buildbot link entirely.
from webrtc-org.
Thanks @hkjellander. I will create a pull request to fix these links in a few minutes.
from webrtc-org.
I have just created the pull request: #136.
from webrtc-org.
For some reason #139 disabled links check. Why?
from webrtc-org.
x1ddos: because it was preventing from adding a new page to the site. It was somehow checking internal link to a new page before adding it.
Edit: it was more tricky - there was an absolute self-link to the newly added page. Because before pull request is merged, the new page was not published, this link was always broken.
from webrtc-org.
any updates?
from webrtc-org.
The link's proofer should be enabled by now. I enabled it here together with fixing some broken links:
#143
from webrtc-org.
Related Issues (20)
- Add the latest Video in the HomePage HOT 2
- Fix broken links from WebRTC homepage.
- Add KITE in the Homepage HOT 1
- Rename ICE to "ISE" HOT 1
- list of security issues is outdated HOT 8
- Add link to Unified Plan migration guide
- onBufferedAmountLow executes too late HOT 4
- outdated release branch information? HOT 1
- what is the state of this repository? HOT 9
- Found a content mistake HOT 1
- frame limitation 10ms error HOT 1
- so where is android/ios version? HOT 1
- Bug in code example on https://webrtc.org/getting-started/media-devices
- VS2017 failed to link to webrtc.lib.
- [build webrtc for Windows x86] peerconnection_client crashed after setting is_clang =false HOT 3
- Chromebook chromeos version 83.0.4103.97 chrome extension webrtc audio to any peer So many noise HOT 1
- WebRTC std::deque iterator exception while running peerconenction_client.exe debug verion HOT 2
- Ask a question about PCC congestion control HOT 1
- DataChannel is not stable HOT 1
- 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webrtc-org.