Comments (8)
Just upgraded to node.js 0.6.18, but I'm not too optimistic...
I really don't understand when socket.write throws an exception and when it emits an 'error' event. You are try/catching exceptions, so either the write must be delayed, or emitting an error event which is not caught by the default http error handler (https://github.com/joyent/node/blob/master/lib/http.js#L1311) for some reason.
Maybe a check if the socket is still writable in completeHandshake
workarounds this, but I'd like to understand it first...
Let's see if node 0.6.18 fixes or at least spits out a better backtrace.
from ws.
Update: it crashed again:
events.js:48
throw arguments[1]; // Unhandled 'error' event
^
Error: This socket is closed.
at Socket._write (net.js:474:19)
at Socket.write (net.js:466:15)
at WebSocketServer.<anonymous> (/home/wwwdocs/applications/services/webpush/node_modules/ws/lib/WebSocketServer.js:292:16)
at /home/wwwdocs/applications/services/webpush/node_modules/ws/lib/WebSocketServer.js:321:25
at WebSocketServer.handleHixieUpgrade (/home/wwwdocs/applications/services/webpush/node_modules/ws/lib/WebSocketServer.js:368:3)
at WebSocketServer.handleUpgrade (/home/wwwdocs/applications/services/webpush/node_modules/ws/lib/WebSocketServer.js:141:61)
at Server.handleUpgrade (/home/wwwdocs/applications/services/webpush/lib/engine/lib/server.js:79:11)
at Server.<anonymous> (/home/wwwdocs/applications/services/webpush/lib/engine/lib/webpush-engine.js:47:12)
at Server.emit (events.js:88:20)
at Socket.<anonymous> (http.js:1521:14)
Now trying to add error
and timeout
handlers to the socket before handleUpgrade.
from ws.
So far no crashes, but I'll observe it over the day.
These handlers should be in ws
as the server should not crash before I (the application) have the chance to react and catch those crashes...
from ws.
Update: still crashes even if I catch the socket's error
event. This is really bad.
events.js:48
throw arguments[1]; // Unhandled 'error' event
^
Error: This socket is closed.
at Socket._write (net.js:474:19)
at Socket.write (net.js:466:15)
at WebSocketServer.<anonymous> (/home/wwwdocs/applications/services/webpush/node_modules/ws/lib/WebSocketServer.js:292:16)
at /home/wwwdocs/applications/services/webpush/node_modules/ws/lib/WebSocketServer.js:321:25
at WebSocketServer.handleHixieUpgrade (/home/wwwdocs/applications/services/webpush/node_modules/ws/lib/WebSocketServer.js:368:3)
at WebSocketServer.handleUpgrade (/home/wwwdocs/applications/services/webpush/node_modules/ws/lib/WebSocketServer.js:141:61)
at Server.handleUpgrade (/home/wwwdocs/applications/services/webpush/lib/engine/lib/server.js:79:11)
at Server.<anonymous> (/home/wwwdocs/applications/services/webpush/lib/engine/lib/webpush-engine.js:47:12)
at Server.emit (events.js:88:20)
at Socket.<anonymous> (http.js:1521:14)
from ws.
I have no idea
- where this happens
- why there is not 'error' handler (as I'm defining one before handing the socket to handleUpgrade)
Now I added a check for socket.writable
before writing the nonce, let's wait some hours to see if this fixes the problem. Sigh.
from ws.
Does #75 work for you? I have a different fix brewing, which seems to be a more long-term way to handle this issue. That'll take me a couple of hours to implement, though.
from ws.
@einaros: so far it seems so...
How would you like to handle it other that that? Seems like node's socket.write is quite a mess, as it can a) throw exceptions b) return false and c) emit an 'error' if something goes wrong...
from ws.
Closing this - let's reiterate if the current fixes aren't sufficient :)
from ws.
Related Issues (20)
- The connection has no header "User-Agent", so that I have stucking in the readyState 0. HOT 2
- Detecting broken connections fails with `RSV1 must be clear` on node v20.11.0 HOT 14
- Dual Triggering of WebSocket Events - ws.on('message') and stream.on('data') HOT 7
- Sec-WebSocket-Accept not found HOT 7
- ws issues with custom hostname HOT 2
- WebSocketServer.address() error needs more context HOT 2
- clientTracking - the client is not destroyed if the server closes or terminates the connection. HOT 2
- The code isn't working. HOT 14
- Is there anyway to disable the websocket closeTimeout? HOT 9
- Unhappy TypeScript when using compilerOptions: module: Node16 || NodeNext HOT 1
- Support sending Blob HOT 13
- WebSocket Ping-Pong Timeout and Connection Closure Failure HOT 3
- terminate() doesnt terminate instantly HOT 6
- ws doesn't work with sveltekit's adapter-cloudflare HOT 4
- Websocket opens randomly not everytime. HOT 5
- While building websocket-api:9.4.48.v20220622 with UAT, failed. (Test Case Failure) HOT 7
- query: difference between ws.onmessage = handler and ws.on('message', handler) HOT 2
- Messages are dispatched while microtask queue is not empty HOT 6
- Uhhh, what does .isAlive do again? HOT 2
- RangeError: Invalid WebSocket frame: MASK must be set HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ws.