Comments (5)
@adioanca-rpma Thanks very much for taking the time to look into this. Would you be willing to put together a pull request with your proposed patch?
Thanks
from gateway.
Done.
@benfrancis @tim-hellhake could you please help with NodeJS 16 build tools docker image?
alongside these:
webthingsio/toolchain-linux-[ARCH]-node-[8|10|12|14]
Thank you
from gateway.
Another thing that I observed was that if one presses Done
in /settings/network/ethernet
screen and dhcp
is the selected option, if there is no Ethernet cable plugged in (or no dhcp server on LAN) it will take 1 minute to get back to /settings/network
screen.
My solution was to add this to image/stage3/02-systemd-units/00-run.sh
:
on_chroot << EOF
# ...
# Faster DHCP for eth0 if there is no link or DHCP server
echo -e "timeout 5;\nretry 1;\npre-up ethtool eth0 | grep -q 'Link detected: yes' || { exit 0; };" >> /etc/dhcp/dhclient.conf
#...
If you want this fix or have a better solution, please let me know.
Thanks
from gateway.
If you want this fix or have a better solution, please let me know.
@adioanca-rpma I don't have another suggestion, no, but please feel free to file a separate issue for that.
I've just noticed that I can't reproduce the bug about static Ethernet settings not being shown in WebThings Gateway 1.1 on a Raspberry Pi, where it seems to work fine. I don't have the current master branch installed on a platform which supports network settings so I can't test that.
Can you confirm which platform you're running on when you experience this bug so that I can try to reproduce it? Is it Raspberry Pi?
I find it odd if this is a regression between 1.1 and master because as far as I'm aware this code hasn't been touched.
Thanks
from gateway.
yes, RPi.
I can reproduce it. branch/commit:
commit 4dadba9a11ec2cadd30353eb9b227bccd5b2b655 (HEAD -> master, origin/master, origin/HEAD)
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Wed Mar 15 05:56:04 2023 +0000
I've just retested now.
To reproduce, try realoading the browser page while in Network (and/or Ethernet page). If you have a static configuration you won't see any of the 3 fields.
Note that once you've changed from dhcp to static, you'll be redirected to network page, and if you go into Ethernet page again - the fields will be visible. And if you change to dhcp, the static fields will remain visible - although they shouldn't.
Try playing static<->dhcp, Network<->Ethernet screens, back and forth and you'll see the issues. Remember to also play with browser page reload.
...
also search the master branch for ipdaddr
and ipaddr
and you'll see that
gateway/static/js/views/settings.js
Line 876 in 627c7c4
d
typo and it's the only place in the project where it appears - which means a static IP is never shown. I don't understand how it works for you... are you seeing the static IP that you have configured? what about after browser page reload or GW restart?from gateway.
Related Issues (20)
- Consider adding `@language` member to `@context` of Thing Descriptions
- Properly implement the `OAuth2SecurityScheme`
- Support `ImageProperty` and `VideoProperty` properties using `forms`
- Missing implementations for adding / removing actions? HOT 1
- Re-factor "context menu" as separate dialogs
- `WebSocket sendMessage failed` when adding a thing to a group HOT 1
- Things get rendered twice HOT 2
- Use new overflow menu design everywhere
- Cannot start container, nodejs error HOT 1
- Confirm deletion of user account
- Confirm removal of add-on HOT 2
- Consider warning users that tunnel can't be configured after first time setup
- Error on startup with docker-compose HOT 2
- Things or "No devices yet" message do not appear on first boot
- Back button on Thing detail view not working
- RPI3+ 1.2.0-alpha.1 - Missing refreshes in 'Things' view ? HOT 1
- WebThings Gateway 1.2 Alpha testing feedback HOT 6
- Zigbee & Z-Wave Things missing properties HOT 4
- MaxListenersExceededWarning: Possible EventEmitter memory leak detected.
- Existing Things have both links and forms after upgrade
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gateway.