Traffic lights show over video playback about webtorrent-desktop HOT 6 CLOSED

I actually don't think this is so bad. I know that Quicktime automatically hides the header (including traffic lights) when the video is playing, but it's harder to do this with Electron.

You can either get a window with native OS buttons, or a completely "frameless" window. You can read about Electron frameless windows.

You can't change the type of window once it's created. I opened an issue to see if the developers could allow setting the frame option dynamically but it was closed: electron/electron#4652

So, the only way to fix this right now would be to use a frameless window and create our own traffic light buttons in CSS and try to make them match the native buttons as closely as possible. This is what Playback does, but it's a bit janky. When Apple released a new OS, we have to manually change the buttons or they will look wrong. And when we do, all the users on old OSs will suddenly see traffic light buttons from an OS they haven't upgraded to yet.

No easy solution here.

from webtorrent-desktop.

Bummer, that's hugely annoying. The solution seems like a lot of work for such a minor change, but at the same time, I really hate overlays when watching videos - it feels similar to when those annoying adverts pop up when you're watching a TV show.

I'm wondering if I should look at Electron itself and see if I can add something to allow for this option.

from webtorrent-desktop.

QuickTime seems to hide the entire titlebar, not purely the traffic light controls. This might mean that we'd have to use the built-in OS X titlebar. Hmm, maybe it's not worth it.

from webtorrent-desktop.

@ChrisMorrisOrg QuickTime seems to hide the entire titlebar, not purely the traffic light controls. This might mean that we'd have to use the built-in OS X titlebar

Even then, I don't think Electron has an API for changing the frame option after a window has been constructed :(

from webtorrent-desktop.

@feross Even then, I don't think Electron has an API for changing the frame option after a window has been constructed :(

Yeah, it seems like too much of a hassle. I've asked a few friends what they thought about the app, and they didn't seem overly concerned about the traffic lights. Maybe it's not worth worrying about at this point in time.

from webtorrent-desktop.

Okay, sounds good to me.

from webtorrent-desktop.