Recent change broke Offset Protocol about kafka-php HOT 4 CLOSED

@AlexKR --^

from kafka-php.

@Crim thanks for issue. looking very strangely, i will try investigate more about it and will commit correct way for error detecting

from kafka-php.

For reference this is running on a x64 machine against kafka 0.8.2.1. Also I didn't test the other code path that has the same change, so not sure if that has issues or not.

from kafka-php.

So I took a stab at this. Looking at PHP Docs for pack here: http://php.net/manual/en/function.pack.php

We were using 'n' to unpack this which says: unsigned short (always 16 bit, big endian byte order)
It got swapped to 's' which says: signed short (always 16 bit, machine byte order)

I'm guessing that your system @AlexKR is big endian, where as mine is little endian, which is why I assume this works for you, but not me.

I opened this PR which attempts to detect the endianess of the system the code is running on, and flips the endianess after unpacking to match and be consistent on either platform.

We/I should probably write a test or two to cover this before it gets merged in tho.

#37

from kafka-php.