Giter VIP home page Giter VIP logo

Comments (7)

tonyabbott avatar tonyabbott commented on June 10, 2024 1

Can't speak to Wayland, but this pre-release has fixed the Xdg-Desktop implementation for me on Ubuntu 22.04.3 Gnome / XOrg, which hasn't been working for some time. My IDEs now correctly track the system light/dark mode where they were previously just stuck in dark mode.

from auto-dark-mode.

Lesik avatar Lesik commented on June 10, 2024 1

Switching to the "xdg-desktop" method works for me on GNOME 43. By the way, I don't think this is a Wayland vs. X11 issue but rather dependent on the GNOME version. In a future version, perhaps this plugin could auto-detect which method to use based on some heuristics like GNOME/GTK version. Keeping the switch in the settings is fine for edge cases, but it would provide for a better OOTB experience.

Thanks for this plugin @weisJ by the way. A lifeeyesaver.

from auto-dark-mode.

weisJ avatar weisJ commented on June 10, 2024

The PR doesn’t reflect the current implementation. See the 2023.1 branch for the latest revision used in version 1.8.1-2023.1. It does use the org.gnome.desktop.interface:color-scheme key. But probably the default and prefer-dark versions aren't handled.

Not sure when I’ll find time to tackle this. It should be an easy fix in GtkVariants though. I’d be happy to review and merge a fix for this :)

from auto-dark-mode.

txomon avatar txomon commented on June 10, 2024

I'm afraid I'm missing too much knowledge on Java/Kotlin to be able to test out stuff without actual pairing :sweat_smile:. I will try to find time in the next couple of weeks and see if I have some luck. One way to maybe lower the bar for contributions could be an standalone cli that works something like:

auto-dark-mode-cli --implementation-type gsettings --guess-light-dark false --change-ide-theme true --ide-theme-light "MyLightTheme" --change-editor-theme true --editor-theme-light "MyEditorLightTheme" --check-high-contrast false

Making this an standalone java cli would make it much easier for me to iterate when testing out by trial and error, as the current setup I achieved forces me to load a whole IDE in debugging mode etc.

from auto-dark-mode.

weisJ avatar weisJ commented on June 10, 2024

Please try out the new pre-release version of the plugin and see whether it fixes the issue for you:
https://plugins.jetbrains.com/plugin/14076-auto-dark-mode/versions/pre-release/387545

from auto-dark-mode.

txomon avatar txomon commented on June 10, 2024

from auto-dark-mode.

txomon avatar txomon commented on June 10, 2024

@tonyabbott are you able to test out the situation I shared? Choose the xdg-desktop settings in the old one, click OK, restart the IDE, and see if it works?

Cheers, Javier

from auto-dark-mode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.